JS: Add taint steps for markdown parsers#5140
Merged
codeql-ci merged 8 commits intogithub:mainfrom Feb 17, 2021
Merged
Conversation
Co-authored-by: intrigus-lgtm <60750685+intrigus-lgtm@users.noreply.github.com>
Contributor
|
OOI, I see you are using local data flow instead of API graphs. Is that due to performance reasons or ergonomics? |
Contributor
Author
Ergonomics. |
asgerf
reviewed
Feb 17, 2021
Contributor
asgerf
left a comment
There was a problem hiding this comment.
Sorry, this fell under my radar for a bit. LGTM, just a minor comment in the change note.
Co-authored-by: Asger F <asgerf@github.com>
asgerf
approved these changes
Feb 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds taint-steps for markdown to HTML converters that doesn't sanitize their outputs.
Evaluation looks fine, with one new TP.