C#: Split up SSA implementation#4959
Merged
Merged
Conversation
7c8ce2d to
238f44a
Compare
f9f29d9 to
0674881
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR splits up
SSA.qllinto four files:SsaImplCommon.qll: This file contains all the language-agnostic details of the SSA implementation. Eventually this file will be shared.SsaImplSpecific.qll: This file contains the C#-specific input to the shared library above. The interface is simple: Define basic blocks, basic block dominance, reads, and writes.SsaImpl.qll: This file contains additional internal C#-specific implementation details.SSA.qll: Contains the exposed SSA interface.https://jenkins.internal.semmle.com/job/Changes/job/CSharp-Differences/772/
Sadly, this PR results in some slow-down, because the cached CFG stage is reevaluated. I tried to avoid it by adding additional
import csharpstatements, but without luck. I have documented the problem here, and I guess we just have to wait for an optimizer fix.