Sitelet https://web.archive.org/web/20210117184250/https://github.com/python/python-docs-es/pull/1137
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

traduce library/modulefinder.po #1137

Merged
merged 6 commits into from Dec 20, 2020
Merged

Conversation

@dvidsilva
Copy link
Contributor

@dvidsilva dvidsilva commented Nov 5, 2020

Closes #812

@mondeja
Copy link
Contributor

@mondeja mondeja commented Nov 5, 2020 •

Hola @dvidsilva. La compilación está fallando porque has reemplazado las cadenas en los msgid. Debes colocar las traducciones en los msgstr y dejar los msgid tal y como están. Por ejemplo, la primera sería:

msgid ":mod:`modulefinder` --- Find modules used by a script"
msgstr ":mod:`modulefinder` --- Encuentra los módulos usados por un script"
@dvidsilva
Copy link
Contributor Author

@dvidsilva dvidsilva commented Nov 5, 2020

ah my bad! ya lo cambio!

@dvidsilva
Copy link
Contributor Author

@dvidsilva dvidsilva commented Nov 5, 2020

@mondeja liston! lost tests running again

Copy link
Contributor

@mondeja mondeja left a comment

Te he dejado algunas sugerencias de corrección. Aplicándolas debería pasar el build de Travis.

library/modulefinder.po Outdated Show resolved Hide resolved
library/modulefinder.po Outdated Show resolved Hide resolved
library/modulefinder.po Outdated Show resolved Hide resolved
library/modulefinder.po Outdated Show resolved Hide resolved
library/modulefinder.po Outdated Show resolved Hide resolved
library/modulefinder.po Outdated Show resolved Hide resolved
library/modulefinder.po Outdated Show resolved Hide resolved
library/modulefinder.po Outdated Show resolved Hide resolved
library/modulefinder.po Outdated Show resolved Hide resolved
library/modulefinder.po Outdated Show resolved Hide resolved
@dvidsilva
Copy link
Contributor Author

@dvidsilva dvidsilva commented Nov 5, 2020

@mondeja genial, puse las correcciones y corrí powrap en el archivo

Copy link
Contributor

@mondeja mondeja left a comment

Perfecto, te he dejado un par de correcciones más 👍

library/modulefinder.po Outdated Show resolved Hide resolved
library/modulefinder.po Outdated Show resolved Hide resolved
@cmaureir
Copy link
Collaborator

@cmaureir cmaureir commented Nov 21, 2020

@dvidsilva te podemos ayudar en algo para finalizar este PR?

@dvidsilva
Copy link
Contributor Author

@dvidsilva dvidsilva commented Nov 23, 2020

@cmaureir perdoname! se me olvido, ya en un ratito pusheo los cambios!

dvidsilva and others added 2 commits Nov 24, 2020
Co-authored-by: Álvaro Mondéjar <mondejar1994@gmail.com>
Co-authored-by: Álvaro Mondéjar <mondejar1994@gmail.com>
@dvidsilva
Copy link
Contributor Author

@dvidsilva dvidsilva commented Nov 24, 2020

@cmaureir accepte los cambios y le di powrap y todo listo!

library/modulefinder.po Show resolved Hide resolved
@dvidsilva
Copy link
Contributor Author

@dvidsilva dvidsilva commented Nov 24, 2020

@mondeja gracias! merged. no tengo auth para merge, pero sientete en libertad de mergiar cuando sea, gracias!

@cmaureir
Copy link
Collaborator

@cmaureir cmaureir commented Nov 25, 2020

voy a cerrar y abrir para ver si pasa la construcción de RTD

@cmaureir cmaureir closed this Nov 25, 2020
@cmaureir cmaureir reopened this Nov 25, 2020
@eamanu
eamanu approved these changes Nov 27, 2020
@cmaureir
Copy link
Collaborator

@cmaureir cmaureir commented Nov 27, 2020

Sigue fallando RTD :/

@dvidsilva
Copy link
Contributor Author

@dvidsilva dvidsilva commented Nov 30, 2020

Ah, de pronto le falta rebase? @cmaureir o que sera? voy a pillar a ver

@dvidsilva dvidsilva force-pushed the dvidsilva:traduccion-modulefinder branch from a6c895d to ee25a6f Nov 30, 2020
@dvidsilva
Copy link
Contributor Author

@dvidsilva dvidsilva commented Nov 30, 2020

@cmaureir no rebase no hizo nada, no se que estará causando el error :(

@cmaureir
Copy link
Collaborator

@cmaureir cmaureir commented Dec 3, 2020

no, realmente no lo sé por qué pueda fallar :/ voy a ver si construyendolo localmente puedo mirar que pasa

@cmaureir cmaureir merged commit 629b44c into python:3.8 Dec 20, 2020
2 checks passed
2 checks passed
Test
Details
docs/readthedocs.org:python-docs-es Read the Docs build succeeded!
Details
@cmaureir
Copy link
Collaborator

@cmaureir cmaureir commented Dec 20, 2020

Gracias @dvidsilva 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.