Sitelet https://web.archive.org/web/20210104142325/https://github.com/bazelbuild/rules_python/pull/398
Skip to content

/ rules_python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not show 'pip3_import' as alternative to 'pip_install' in README #398

Open
wants to merge 1 commit into
base: master
from
Open

Do not show 'pip3_import' as alternative to 'pip_install' in README #398

wants to merge 1 commit into from

Conversation

@thundergolfer
Copy link
Collaborator

@thundergolfer thundergolfer commented Jan 3, 2021

Partially addresses #397, specifically:

Then I read the instructions again, tried pip3_import, which doesn't exist (under pip.bzl). ...

pip3_import is legacy now and not provided in python/pip.bzl, so shouldn't be commented as an alternative to pip_install.

cc @dayfine

PR Checklist

Please check if your PR fulfills the following requirements:

  • Does not include precompiled binaries, eg. .par files. See CONTRIBUTING.md for info
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Other information
@thundergolfer
do not show 'pip3_import' as alternative to 'pip_install' in README
Loading status checks…
341a13c
@thundergolfer thundergolfer requested a review from andyscott as a code owner Jan 3, 2021
@google-cla google-cla bot added the cla: yes label Jan 3, 2021
@thundergolfer thundergolfer requested a review from hrfuller Jan 3, 2021
@hrfuller
hrfuller approved these changes Jan 3, 2021
View changes
Copy link
Collaborator

@hrfuller hrfuller left a comment

Lgtm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hrfuller hrfuller

@andyscott andyscott

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@thundergolfer @hrfuller
You can’t perform that action at this time.