Sitelet https://web.archive.org/web/20210103225711/https://github.com/excalidraw/excalidraw/issues/2458
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep drawing mode #2458

Open
ahmedash95 opened this issue Dec 6, 2020 · 9 comments
Open

Keep drawing mode #2458

ahmedash95 opened this issue Dec 6, 2020 · 9 comments

Comments

@ahmedash95
Copy link

@ahmedash95 ahmedash95 commented Dec 6, 2020

Hello,
First of all thanks for this great project. and I'm sorry if the title is not clear enough.

The problem right now is if you want to keep drawing with the pencil. every time you release the mouse you will have to select the pencil again. because it auto selects the shape once you release the mouse. I think there should be an option to keep drawing and that way you can keep drawing without selecting the pencil every time.

image

Thank you!

@lipis
Copy link
Member

@lipis lipis commented Dec 6, 2020

Press on the last icon: the locker :)

@vjeux
Copy link
Contributor

@vjeux vjeux commented Dec 6, 2020

We should make the lock by default when enabling the pencil. The current behavior is not intuitive.

@lipis
Copy link
Member

@lipis lipis commented Dec 6, 2020

@vjeux should we enable lock when pressing the draw item.. or just not changing it to selection after it's done without affecting the lock? (Because then we'll have to unlock it if pressed on something else and the lock was automatically enabled)

@dwelle
Copy link
Member

@dwelle dwelle commented Dec 6, 2020 •

@lipis yes, this why I stalled on implementing it because it's not clear how this seemingly simple feature should behave :/.

I guess we'll need to keep track of previous state and reset the lock only if previous state wasn't locked to begin with.

@lipis
Copy link
Member

@lipis lipis commented Dec 6, 2020

or just ignore the lock for the draw tool and not reset it to selection after it's done. Regardless of the lock.

@ahmedash95
Copy link
Author

@ahmedash95 ahmedash95 commented Dec 6, 2020

I did not notice the lock at all :D my problem is solved now. but +1 for @lipis suggestion. to ignore the lock for the draw tool.

Regards

@mwufi
Copy link
Contributor

@mwufi mwufi commented Dec 12, 2020

@lipis do we... want to implement this? :) I can submit a PR (new contributor here!)

@lipis
Copy link
Member

@lipis lipis commented Dec 12, 2020 •

@mwufi Sure.. go for it.. and we'll iterate over the PR. My idea is to not use the lock icon at all.. just not going back to the selection after the draw is done.

@lipis lipis assigned lipis and mwufi and unassigned lipis Dec 12, 2020
@lipis lipis changed the title Feature request: Keep drawing mode Keep drawing mode Dec 14, 2020
@dwelle
Copy link
Member

@dwelle dwelle commented Jan 2, 2021

@mwufi still wanna work on this?

@lipis lipis pinned this issue Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.