fix(compiler): incorrectly inferring content type of SVG-specific title tag #40259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoostK
reviewed
Dec 24, 2020
WDYT about adding some tests to packages/compiler/test/ml_parser/lexer_spec.ts, e.g. testing the simple case but also testing with child elements?
|
Sure. By "testing with child elements", do you mean having a |
|
A |
5cb45e3
to
18fa418
Compare
|
The extra unit tests have been added. |
…le tag The parser has a list of tag definitions that it uses when parsing the template. Each tag has a `contentType` which tells the parser what kind of content the tag should contain. The problem is that the browser has two separate `title` tags (`HTMLTitleElement` and `SVGTitleElement`) and each of them has to have a different `contentType`, otherwise the parser will throw an error further down the pipeline. These changes update the tag definitions so that each tag name can have multiple content types associated with it and the correct one can be returned based on the element's prefix. Fixes angular#31503.
18fa418
to
693fbf1
Compare
JoostK
approved these changes
Jan 11, 2021
|
Merge assistance: needs a presubmit. |
atscott
approved these changes
Jan 11, 2021
atscott
added a commit
that referenced
this issue
Jan 11, 2021
…le tag (#40259) The parser has a list of tag definitions that it uses when parsing the template. Each tag has a `contentType` which tells the parser what kind of content the tag should contain. The problem is that the browser has two separate `title` tags (`HTMLTitleElement` and `SVGTitleElement`) and each of them has to have a different `contentType`, otherwise the parser will throw an error further down the pipeline. These changes update the tag definitions so that each tag name can have multiple content types associated with it and the correct one can be returned based on the element's prefix. Fixes #31503. PR Close #40259
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The parser has a list of tag definitions that it uses when parsing the template. Each tag has a
contentTypewhich tells the parser what kind of content the tag should contain. The problem is that the browser has two separatetitletags (HTMLTitleElementandSVGTitleElement) and each of them has to have a differentcontentType, otherwise the parser will throw an error further down the pipeline.These changes update the tag definitions so that each tag name can have multiple content types associated with it and the correct one can be returned based on the element's prefix.
Fixes #31503.