Conversation
| # Recursive Python3 program to find if a given pattern is | ||
| # present in a text | ||
|
|
||
| def exactMatch(text, pat, text_index, pat_index): |
There was a problem hiding this comment.
The function name should be snake_case as described in CONTRIBUTING.md.
| def exactMatch(text, pat, text_index, pat_index): | |
| def exact_match(text, pat, text_index, pat_index): |
Type hints and doctests are also required :)
| @@ -0,0 +1,26 @@ | |||
| def is_Sublist(l, s): | |||
There was a problem hiding this comment.
| def is_Sublist(l, s): | |
| def is_sublist(l, s): |
|
You clearly checked multiple boxes without fulfilling the requirements. You should have done two pull requests, one for each file. These should contain doctests and typehints for every function. |
|
Follow these steps in order to go good:
|
|
@algorithms-keeper review |
ghost
left a comment
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will only modify the labels accordingly.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| # Recursive Python3 program to find if a given pattern is | ||
| # present in a text | ||
|
|
||
| def exact_match(text, pat, text_index, pat_index): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file searches/recursive_substring_search.py, please provide doctest for the function exact_match
Please provide return type hint for the function: exact_match. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: text
Please provide type hint for the parameter: pat
Please provide type hint for the parameter: text_index
Please provide type hint for the parameter: pat_index
|
|
||
|
|
||
| # This function returns true if 'text' contain 'pat' | ||
| def contains(text, pat, text_index, pat_index): |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file searches/recursive_substring_search.py, please provide doctest for the function contains
Please provide return type hint for the function: contains. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: text
Please provide type hint for the parameter: pat
Please provide type hint for the parameter: text_index
Please provide type hint for the parameter: pat_index
| @@ -0,0 +1,26 @@ | |||
| def is_sublist(l, s): | |||
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file searches/sublist_search.py, please provide doctest for the function is_sublist
Please provide return type hint for the function: is_sublist. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide descriptive name for the parameter: l
Please provide type hint for the parameter: l
Please provide descriptive name for the parameter: s
Please provide type hint for the parameter: s
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Please reopen this pull request once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to seek help from our Gitter or ping one of the reviewers. Thank you for your contributions! |
Describe your change:
Added sublist search
Checklist:
Fixes: #{$ISSUE_NO}.