Sitelet https://web.archive.org/web/20250514163023/https://github.com/angular/angular/pull/40012
Skip to content

fix(dev-infra): allow build-worker to be used in forked process #40012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

fix(dev-infra): allow build-worker to be used in forked process #40012

wants to merge 3 commits into from

Conversation

josephperrott
Copy link
Member

Generates a local copy of the build-worker file to allow it to be loaded
at runtime in a forked process.

@josephperrott josephperrott added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Dec 7, 2020
@google-cla google-cla bot added the cla: yes label Dec 7, 2020
@josephperrott josephperrott mentioned this pull request Dec 7, 2020
Closed
@josephperrott josephperrott marked this pull request as ready for review December 7, 2020 19:02
@josephperrott josephperrott force-pushed the create-build-worker-script branch from 92c6a8a to 8950e50 Compare December 7, 2020 19:49
@josephperrott josephperrott added area: build & ci Related the build and CI infrastructure of the project area: dev-infra Issues related to Angular's own dev infra (build, test, CI, releasing) labels Dec 7, 2020
@ngbot ngbot bot modified the milestone: Backlog Dec 7, 2020
devversion
devversion approved these changes Dec 8, 2020
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

gkalpak
gkalpak approved these changes Dec 8, 2020
View reviewed changes
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gkalpak gkalpak added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 8, 2020
@josephperrott
fix(dev-infra): allow build-worker to be used in forked process
19e7354 
Generates a local copy of the build-worker file to allow it to be loaded
at runtime in a forked process.
@josephperrott
build: exclude build-worker file from formatting
da6b9c5 
Exclude the generated build-worker.js file from formatting as it is
generated and not subject to formatting restrictions.
@josephperrott
fixup! fix(dev-infra): allow build-worker to be used in forked process
17dafdf
@josephperrott josephperrott force-pushed the create-build-worker-script branch from 8950e50 to 17dafdf Compare December 8, 2020 17:09
@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Dec 8, 2020
@mhevery mhevery added target: minor This PR is targeted for the next minor release target: patch This PR is targeted for the next patch release and removed target: patch This PR is targeted for the next patch release target: minor This PR is targeted for the next minor release labels Dec 8, 2020
@mhevery mhevery closed this in c043ecf Dec 8, 2020
mhevery pushed a commit that referenced this pull request Dec 8, 2020
@josephperrott @mhevery
build: exclude build-worker file from formatting (#40012)
c051693 
Exclude the generated build-worker.js file from formatting as it is
generated and not subject to formatting restrictions.

PR Close #40012
mhevery pushed a commit that referenced this pull request Dec 8, 2020
@josephperrott @mhevery
fix(dev-infra): allow build-worker to be used in forked process (#40012)
5fada68 
Generates a local copy of the build-worker file to allow it to be loaded
at runtime in a forked process.

PR Close #40012
mhevery pushed a commit that referenced this pull request Dec 8, 2020
@josephperrott @mhevery
build: exclude build-worker file from formatting (#40012)
ef26197 
Exclude the generated build-worker.js file from formatting as it is
generated and not subject to formatting restrictions.

PR Close #40012
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 8, 2021
@josephperrott josephperrott deleted the create-build-worker-script branch August 31, 2023 17:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@gkalpak gkalpak gkalpak approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project area: dev-infra Issues related to Angular's own dev infra (build, test, CI, releasing) cla: yes target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
4 participants
@josephperrott @devversion @gkalpak @mhevery