Sitelet https://web.archive.org/web/20201223145625/https://github.com/freeCodeCamp/devdocs/issues/1326
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenJDK 11 scrapper does not pick fragment links #1326

Open
etanol opened this issue Nov 16, 2020 · 0 comments
Open

OpenJDK 11 scrapper does not pick fragment links #1326

etanol opened this issue Nov 16, 2020 · 0 comments
Labels

Comments

@etanol
Copy link

@etanol etanol commented Nov 16, 2020 •

The OpenJDK documentation structure changed slightly between the 8 and 11 releases. One particular change is that anchor names are no longer used. Instead, the Javadoc HTML uses anchor ids. In other words, the linkable parts of a single page went from:

<a name="mapToLong-java.util.function.ToLongFunction-">

In version 8, to:

<a id="mapToLong(java.util.function.ToLongFunction)">

In version 11. Note also the use of parenthesis in method identifiers. Because the current scrapper is not able to identify anchor points in the OpenJDK 11 documentation, the method names are not being indexed and inner page links don't work either.

I believe the fix for this would consist of updating this block with two alternative versions:

  • One for version 8, just as it is
  • Another one for version 11, replacing css('a[name]') with css('a[id]')

I currently don't have the expertise to prepare and test a patch, so I'm reporting this just in case someone else can fix it in a shorter time. However, if nobody else can I'll try to do it myself in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.