Sitelet https://web.archive.org/web/20200911145436/https://github.com/akka/akka/issues/27040
Skip to content

/ akka

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate all SBT dependency configs in Dependencies.scala to LibraryManagementSyntax type vs string #27040

Open
helena opened this issue May 28, 2019 · 13 comments · May be fixed by #27422
Open

Migrate all SBT dependency configs in Dependencies.scala to LibraryManagementSyntax type vs string #27040

helena opened this issue May 28, 2019 · 13 comments · May be fixed by #27422
Labels
1 - triaged good first issue hackathon t:build

Comments

@helena
Copy link
Member

@helena helena commented May 28, 2019

No description provided.

@helena helena added the t:build label May 28, 2019
@helena helena self-assigned this May 28, 2019
@helena helena mentioned this issue May 28, 2019
Merged
@chbatey chbatey added the hackathon label May 29, 2019
@chbatey
Copy link
Member

@chbatey chbatey commented May 29, 2019

Might be good for hackathon instead
@jrudolph
Copy link
Member

@jrudolph jrudolph commented May 29, 2019

@helena Can you clarify or give an example in the description?
@helena
Copy link
Member Author

@helena helena commented May 31, 2019

@jrudolph

from
val commonsMath = "org.apache.commons" % "commons-math" % "2.2" % "test"

to
val commonsMath = "org.apache.commons" % "commons-math" % "2.2" % Test

e.g. Test, Optional, Provided, whatever is the non string type version of a given dependency configuration.
It's a small change, not hackathon worthy IMO.
@jrudolph
Copy link
Member

@jrudolph jrudolph commented Jun 4, 2019

Ah, thanks, didn't know this syntax so far. Might still make a good thing for someone to get started with setting up Akka.
@helena helena removed their assignment Jun 27, 2019
@jakeashdown
Copy link

@jakeashdown jakeashdown commented Jul 17, 2019

Hi guys, I haven't contributed to Akka before and I'd like to take this ticket. That okay?
@raboof
Copy link
Member

@raboof raboof commented Jul 18, 2019

@jakeashdown sure, go ahead!

(this might be a slightly tricky because we introduce objects with those names in Dependencies.scala, but I think those can be renamed)
@jakeashdown
Copy link

@jakeashdown jakeashdown commented Jul 18, 2019

Cool, I'll take a look
@helena
Copy link
Member Author

@helena helena commented Jul 18, 2019

The thing to consider here you'll have to rename a bit due to the internal Dependencies.Test object and sbt Test config.
@chbatey chbatey added the 1 - triaged label Jul 22, 2019
@jakeashdown
Copy link

@jakeashdown jakeashdown commented Jul 25, 2019

Sorry it's taken me a while to look at this - I'm working on an underpowered laptop which is unable to run sbt and intellij for this project at the same time. I'm now using sbt -mem 6144 and editing with Atom, which works okay. Should have this done soon.
jakeashdown added a commit to jakeashdown/akka that referenced this issue Jul 26, 2019
@jakeashdown
Change "test" dependency config to LibraryManagementSyntax type (akka…
b79e5bb 
…#27040)

* Rename Test object to TestDependencies, to avoid duplicate import
* Alias TestDependencies import to Test, for brevity
* Replace "test" strings with Test type
jakeashdown added a commit to jakeashdown/akka that referenced this issue Jul 26, 2019
@jakeashdown
Change "provided" dependency config to LibraryManagementSyntax type (a…
797bade 
…kka#27040)

* Rename Provided object to ProvidedDependencies, to avoid duplicate import
* Alias ProvidedDependencies import to Provided, for brevity
* Replace "provide" strings with Provided type
* Replace all other configuration strings with the correct type
* For any ModuleID with multiple configurations, replace this with Seq[ModuleID]
  containing a ModluleID for each configuration
jakeashdown added a commit to jakeashdown/akka that referenced this issue Jul 26, 2019
@jakeashdown
Remove last use of "compile" configuration (akka#27040)
766dac7
@jakeashdown jakeashdown linked a pull request that will close this issue Jul 26, 2019
Open
jakeashdown added a commit to jakeashdown/akka that referenced this issue Aug 6, 2019
@jakeashdown
Reorder dependency configurations from Compile to Provided (akka#27040)
106dda3
jakeashdown added a commit to jakeashdown/akka that referenced this issue Aug 6, 2019
@jakeashdown
Create variables for sigar-loader name and organisation (akka#27040)
1300eb6
@sakshiganeriwal
Copy link

@sakshiganeriwal sakshiganeriwal commented Oct 2, 2019

Hello everyone,
Is someone already working on this?
I'd like to take this issue if no one is currently working. is that okay?
@helena
Copy link
Member Author

@helena helena commented Oct 2, 2019

Hi @sakshiganeriwal, thanks for your interest in it! We somehow let the current PR for it slide in review cycles but it's almost complete. We hope you find another that sounds good to contribute :)
@sakshiganeriwal
Copy link

@sakshiganeriwal sakshiganeriwal commented Oct 2, 2019

sure. thanks. do you have any suggestions ?
it's my first time.
@helena
Copy link
Member Author

@helena helena commented Oct 2, 2019

One of these would be great:
#25468
#25467
Labels to look for are: good first issue, hackathon, help wanted (that are not marked in progress)
raboof added a commit to jakeashdown/akka that referenced this issue Oct 4, 2019
@jakeashdown @raboof
Change "test" dependency config to LibraryManagementSyntax type (akka…
Verified
This commit was signed with a verified signature.
raboof Arnout Engelen
GPG key ID: BB8C0F854A1E2105 Learn about signing commits
f1702b9 
…#27040)

* Rename Test object to TestDependencies, to avoid duplicate import
* Alias TestDependencies import to Test, for brevity
* Replace "test" strings with Test type
raboof added a commit to jakeashdown/akka that referenced this issue Oct 4, 2019
@jakeashdown @raboof
Change "provided" dependency config to LibraryManagementSyntax type (a…
Verified
This commit was signed with a verified signature.
raboof Arnout Engelen
GPG key ID: BB8C0F854A1E2105 Learn about signing commits
2714d41 
…kka#27040)

* Rename Provided object to ProvidedDependencies, to avoid duplicate import
* Alias ProvidedDependencies import to Provided, for brevity
* Replace "provide" strings with Provided type
* Replace all other configuration strings with the correct type
* For any ModuleID with multiple configurations, replace this with Seq[ModuleID]
  containing a ModluleID for each configuration
raboof added a commit to jakeashdown/akka that referenced this issue Oct 4, 2019
@jakeashdown @raboof
Remove last use of "compile" configuration (akka#27040)
Verified
This commit was signed with a verified signature.
raboof Arnout Engelen
GPG key ID: BB8C0F854A1E2105 Learn about signing commits
b4c5268
raboof added a commit to jakeashdown/akka that referenced this issue Oct 4, 2019
@jakeashdown @raboof
Reorder dependency configurations from Compile to Provided (akka#27040)
Verified
This commit was signed with a verified signature.
raboof Arnout Engelen
GPG key ID: BB8C0F854A1E2105 Learn about signing commits
2f90991
raboof added a commit to jakeashdown/akka that referenced this issue Oct 4, 2019
@jakeashdown @raboof
Create variables for sigar-loader name and organisation (akka#27040)
Verified
This commit was signed with a verified signature.
raboof Arnout Engelen
GPG key ID: BB8C0F854A1E2105 Learn about signing commits
d6b3793
raboof added a commit to jakeashdown/akka that referenced this issue Mar 26, 2020
@jakeashdown @raboof
Change "test" dependency config to LibraryManagementSyntax type (akka…
0f8d017 
…#27040)

* Rename Test object to TestDependencies, to avoid duplicate import
* Alias TestDependencies import to Test, for brevity
* Replace "test" strings with Test type
raboof added a commit to jakeashdown/akka that referenced this issue Mar 26, 2020
@jakeashdown @raboof
Change "provided" dependency config to LibraryManagementSyntax type (a…
f270cf8 
…kka#27040)

* Rename Provided object to ProvidedDependencies, to avoid duplicate import
* Alias ProvidedDependencies import to Provided, for brevity
* Replace "provide" strings with Provided type
* Replace all other configuration strings with the correct type
* For any ModuleID with multiple configurations, replace this with Seq[ModuleID]
  containing a ModluleID for each configuration
raboof added a commit to jakeashdown/akka that referenced this issue Mar 26, 2020
@jakeashdown @raboof
Remove last use of "compile" configuration (akka#27040)
6097b0c
raboof added a commit to jakeashdown/akka that referenced this issue Mar 26, 2020
@jakeashdown @raboof
Reorder dependency configurations from Compile to Provided (akka#27040)
0a65575
raboof added a commit to jakeashdown/akka that referenced this issue Mar 26, 2020
@jakeashdown @raboof
Create variables for sigar-loader name and organisation (akka#27040)
8f2ed9e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 - triaged good first issue hackathon t:build
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Wip 27040 migrate dependency configuration strings to proper types
6 participants
@jrudolph @raboof @helena @chbatey @sakshiganeriwal @jakeashdown
You can’t perform that action at this time.