Sitelet https://web.archive.org/web/20201221214839/https://github.com/flutter/flutter/pull/72548
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update various API docs #72548

Merged
merged 1 commit into from Dec 17, 2020
Merged

Update various API docs #72548

merged 1 commit into from Dec 17, 2020

Conversation

@tvolkert
Copy link
Contributor

@tvolkert tvolkert commented Dec 17, 2020

Description

This adds answers in the docs for various questions I had run into over the past few months, in the places where I looked for the answers.

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • No, no existing tests failed, so this is not a breaking change.
@tvolkert tvolkert requested review from Hixie and goderbauer Dec 17, 2020
@flutter-dashboard
Copy link

@flutter-dashboard flutter-dashboard bot commented Dec 17, 2020

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Hixie
Copy link
Contributor

@Hixie Hixie commented Dec 17, 2020

Test exempt; documentation fixes.

@Hixie
Hixie approved these changes Dec 17, 2020
Copy link
Contributor

@Hixie Hixie left a comment

LGTM

Copy link
Member

@goderbauer goderbauer left a comment

LGTM

@tvolkert tvolkert merged commit becf09c into flutter:master Dec 17, 2020
36 of 37 checks passed
36 of 37 checks passed
Google testing No tests has been executed due to internal error. Ask a Googler to investigate.
Details
Linux analyze
Details
Linux build_gallery
Details
Linux build_tests
Details
Linux customer_testing
Details
Linux docs
Details
Linux firebase_abstract_method_smoke_test
Details
Linux firebase_android_embedding_v2_smoke_test
Details
Linux firebase_release_smoke_test
Details
Linux flutter_plugins
Details
Linux framework_tests
Details
Linux fuchsia_precache
Details
Linux web_e2e_test
Details
Linux web_integration_tests
Details
Linux web_long_running_tests
Details
Linux web_smoke_test
Details
Linux web_tests
Details
Mac build_gallery
Details
Mac build_tests
Details
Mac customer_testing
Details
Mac framework_tests
Details
WIP Ready for review
Details
Windows build_tests
Details
Windows customer_testing
Details
Windows framework_tests
Details
Windows tool_tests
Details
analyze-linux Task Summary
Details
cla/google All necessary CLAs are signed
customer_testing-linux Task Summary
Details
docs-linux Task Summary
Details
flutter-build
Details
flutter-gold All golden file tests have passed.
Details
framework_tests-libraries-linux Task Summary
Details
framework_tests-misc-linux Task Summary
Details
framework_tests-widgets-linux Task Summary
Details
web_integration_tests Task Summary
Details
web_smoke_test Task Summary
Details
@tvolkert tvolkert deleted the tvolkert:docs branch Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.