Sitelet https://web.archive.org/web/20201218185212/https://github.com/mui-org/material-ui/issues/24046
Skip to content

/ material-ui

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collapse documentation says `hidden` style is applied when `collapsedHeight != 0px`, but code shows `collapsedHeight === 0px` #24046

Open
ShaggyKris opened this issue Dec 18, 2020 · 1 comment
Open

Collapse documentation says `hidden` style is applied when `collapsedHeight != 0px`, but code shows `collapsedHeight === 0px` #24046

ShaggyKris opened this issue Dec 18, 2020 · 1 comment
Labels
component: Collapse docs good first issue

Comments

@ShaggyKris
Copy link

@ShaggyKris ShaggyKris commented Dec 18, 2020

material-ui/packages/material-ui/src/Collapse/Collapse.js

Line 202 in 7646db1

[classes.hidden]: state === 'exited' && !inProp && collapsedHeight === '0px',

https://material-ui.com/api/collapse/#css
@eps1lon
Copy link
Member

@eps1lon eps1lon commented Dec 18, 2020

Good catch. Would you be willing to open a PR?

We need to change

material-ui/packages/material-ui/src/Collapse/Collapse.js

Line 34 in 259253d

/* Styles applied to the root element when the transition has exited and `collapsedSize` != 0px. */
,

material-ui/packages/material-ui/src/Collapse/Collapse.d.ts

Line 21 in 259253d

/** Styles applied to the root element when the transition has exited and `collapsedSize` != 0px. */
and then run yarn docs:api.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: Collapse docs good first issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@ShaggyKris @eps1lon
You can’t perform that action at this time.