Sitelet https://web.archive.org/web/20201219231104/https://github.com/PowerShell/PowerShell/pull/14354
Skip to content

/ PowerShell

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade StyleCopAnalyzers to v1.2.0-beta.312 #14354

Merged
merged 1 commit into from Dec 12, 2020
Merged

Upgrade StyleCopAnalyzers to v1.2.0-beta.312 #14354

merged 1 commit into from Dec 12, 2020

Conversation

@xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Dec 8, 2020

https://github.com/DotNetAnalyzers/StyleCopAnalyzers/releases/tag/1.2.0-beta.312

Supercedes #14333.

Follow-up to #14293.
@xtqqczze
Upgrade StyleCopAnalyzers to v1.2.0-beta.312
Loading status checks…
864aee5 
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/releases/tag/1.2.0-beta.312

Supercedes #14333.

Follow-up to #14293.
@xtqqczze xtqqczze mentioned this pull request Dec 8, 2020
Closed
@xtqqczze
Copy link
Contributor Author

@xtqqczze xtqqczze commented Dec 9, 2020

@iSazonov Could you please approve changes.
@iSazonov
iSazonov approved these changes Dec 9, 2020
View changes
@xtqqczze
Copy link
Contributor Author

@xtqqczze xtqqczze commented Dec 9, 2020 •
edited

@iSazonov @RDIL I asked about using dependabot for StyleCopAnalyzers at dotnet/runtime#45779.
@iSazonov
Copy link
Collaborator

@iSazonov iSazonov commented Dec 9, 2020

@iSazonov @RDIL I asked about using dependabot for StyleCopAnalyzers at dotnet/runtime#45779.

They are large team and they can track manually.

We don't configure dependabot to auto-merge so I am ok if dependabot will create new PRs but only if new versions are not released frequently (monthly?).
@xtqqczze
Copy link
Contributor Author

@xtqqczze xtqqczze commented Dec 9, 2020 •
edited by unfurl-links bot

@iSazonov @RDIL I asked about using dependabot for StyleCopAnalyzers at dotnet/runtime#45779.

They are large team and they can track manually.

We don't configure dependabot to auto-merge so I am ok if dependabot will create new PRs but only if new versions are not released frequently (monthly?).

I think releases may be more frequent until C# 9.0 support is complete. But generally releases happen less often, see https://github.com/DotNetAnalyzers/StyleCopAnalyzers/releases.

GitHub
An implementation of StyleCop rules using the .NET Compiler Platform - DotNetAnalyzers/StyleCopAnalyzers
@daxian-dbw
daxian-dbw approved these changes Dec 12, 2020
View changes
@daxian-dbw daxian-dbw merged commit 41cfc4e into PowerShell:master Dec 12, 2020
32 checks passed
32 checks passed
Analyze (csharp)
Details
CodeQL No new alerts
Details
CodeFactor No issues found.
Details
PowerShell-CI-linux Build #PR-14354-20201208.01 succeeded
Details
PowerShell-CI-linux (Build for Linux linux Build) Build for Linux linux Build succeeded
Details
PowerShell-CI-linux (CodeCoverage and Test Packages CodeCoverage and Test Packages) CodeCoverage and Test Packages CodeCoverage and Test Packages succeeded
Details
PowerShell-CI-linux (Test for Linux Linux Test - ElevatedPesterTests - CI) Test for Linux Linux Test - ElevatedPesterTests - CI succeeded
Details
PowerShell-CI-linux (Test for Linux Linux Test - ElevatedPesterTests - Others) Test for Linux Linux Test - ElevatedPesterTests - Others succeeded
Details
PowerShell-CI-linux (Test for Linux Linux Test - UnelevatedPesterTests - CI) Test for Linux Linux Test - UnelevatedPesterTests - CI succeeded
Details
PowerShell-CI-linux (Test for Linux Linux Test - UnelevatedPesterTests - Others) Test for Linux Linux Test - UnelevatedPesterTests - Others succeeded
Details
PowerShell-CI-linux (Test for Linux Verify xUnit Results) Test for Linux Verify xUnit Results succeeded
Details
PowerShell-CI-macos Build #PR-14354-20201208.01 succeeded
Details
PowerShell-CI-macos (Build for macOS macOS Build) Build for macOS macOS Build succeeded
Details
PowerShell-CI-macos (CodeCoverage and Test Packages CodeCoverage and Test Packages) CodeCoverage and Test Packages CodeCoverage and Test Packages succeeded
Details
PowerShell-CI-macos (Test for macOS Verify xUnit Results) Test for macOS Verify xUnit Results succeeded
Details
PowerShell-CI-macos (Test for macOS mac Test - ElevatedPesterTests - CI) Test for macOS mac Test - ElevatedPesterTests - CI succeeded
Details
PowerShell-CI-macos (Test for macOS mac Test - ElevatedPesterTests - Others) Test for macOS mac Test - ElevatedPesterTests - Others succeeded
Details
PowerShell-CI-macos (Test for macOS mac Test - UnelevatedPesterTests - CI) Test for macOS mac Test - UnelevatedPesterTests - CI succeeded
Details
PowerShell-CI-macos (Test for macOS mac Test - UnelevatedPesterTests - Others) Test for macOS mac Test - UnelevatedPesterTests - Others succeeded
Details
PowerShell-CI-static-analysis Build #PR-14354-20201208.01 succeeded
Details
PowerShell-CI-static-analysis (Markdown and Common Tests) Markdown and Common Tests succeeded
Details
PowerShell-CI-static-analysis (Secret Scan) Secret Scan succeeded
Details
PowerShell-CI-windows Build #PR-14354-20201208.01 succeeded
Details
PowerShell-CI-windows (Build for Windows Windows Build) Build for Windows Windows Build succeeded
Details
PowerShell-CI-windows (Packaging for Windows Windows Packaging) Packaging for Windows Windows Packaging succeeded
Details
PowerShell-CI-windows (Test for Windows Verify xUnit Results) Test for Windows Verify xUnit Results succeeded
Details
PowerShell-CI-windows (Test for Windows Windows Test - ElevatedPesterTests - CI) Test for Windows Windows Test - ElevatedPesterTests - CI succeeded
Details
PowerShell-CI-windows (Test for Windows Windows Test - ElevatedPesterTests - Others) Test for Windows Windows Test - ElevatedPesterTests - Others succeeded
Details
PowerShell-CI-windows (Test for Windows Windows Test - UnelevatedPesterTests - CI) Test for Windows Windows Test - UnelevatedPesterTests - CI succeeded
Details
PowerShell-CI-windows (Test for Windows Windows Test - UnelevatedPesterTests - Others) Test for Windows Windows Test - UnelevatedPesterTests - Others succeeded
Details
WIP Ready for review
Details
license/cla All CLA requirements met.
@iSazonov iSazonov added this to the 7.2.0-preview.2 milestone Dec 12, 2020
@xtqqczze xtqqczze deleted the xtqqczze:upgrade-stylecop branch Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxian-dbw daxian-dbw

@iSazonov iSazonov

@TravisEz13 TravisEz13

@anmenaga anmenaga

@adityapatwardhan adityapatwardhan

Assignees

@daxian-dbw daxian-dbw

Labels
CL-Tools
Projects
None yet
Milestone
7.2.0-preview.2
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@xtqqczze @iSazonov @daxian-dbw
You can’t perform that action at this time.