Sitelet https://web.archive.org/web/20201202103743/https://github.com/rapidsai/cuml/issues/2621
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Information about treelite Operator values passed in FIL's C++ test #2621

Open
Salonijain27 opened this issue Jul 29, 2020 · 3 comments
Open

Comments

@Salonijain27
Copy link
Contributor

@Salonijain27 Salonijain27 commented Jul 29, 2020

Report needed documentation

We do not have documentation specifying the different treelite Operator values that FIL supports. (https://github.com/dmlc/treelite/blob/46c8390aed4491ea97a017d447f921efef9f03ef/include/treelite/base.h#L40)

Report needed documentation
https://github.com/rapidsai/cuml/blob/branch-0.15/cpp/test/sg/fil_test.cu
There are multiple places in the fil_test.cu file where we pass treelite Operator values like : kLT, kLE, kGT and so on. But we do not specify the options that FIL does and does not support.

Describe the documentation you'd like
Add a couple of lines explaining the different treelite operators FIL supports and any limitations of using them. ex. Maybe some options are not supported for multi-class classification.

@github-actions github-actions bot added this to Needs prioritizing in Other Issue Triage Jul 29, 2020
@drobison00
Copy link
Contributor

@drobison00 drobison00 commented Jul 30, 2020

@levsnv Looks like you're one of the last ones in this file. Does this request require much familiarity with the code, or a good first task for someone?

@levsnv
Copy link
Contributor

@levsnv levsnv commented Jul 31, 2020

Hi Devin, we're discussing it, will try to post something tomorrow. Thanks!

@levsnv
Copy link
Contributor

@levsnv levsnv commented Aug 1, 2020

Yes, this is a good first task.
WRT treelite operators (kLT and such), multi-class works exactly the same way, because only the leaf label is different (categorical). Worth double-checking, but FIL might be supporting all operators treelite supports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Other Issue Triage
Needs prioritizing
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.