Sitelet https://web.archive.org/web/20201206212242/https://github.com/apache/kibble/issues/84
Skip to content

/ kibble

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor KibbleDatabase #84

Open
turbaszek opened this issue Oct 27, 2020 · 3 comments
Open

Refactor KibbleDatabase #84

turbaszek opened this issue Oct 27, 2020 · 3 comments
Assignees
@turbaszek
Labels
kind:feature

Comments

@turbaszek
Copy link
Contributor

@turbaszek turbaszek commented Oct 27, 2020 •
edited

Currently we implement two times the same class: KibbleDatabase:

kibble/kibble/setup/makeaccount.py

Line 27 in 2abfcc8

class KibbleDatabase(object):

kibble/kibble/api/plugins/database.py

Line 121 in 2abfcc8

class KibbleDatabase(object):

What should be done:

  1. We should consolidate the whole logic into single class and create kibble/database.py that will keep definition of this object.
  2. Refactor this class to use values from KibbleConfigParser from kibble/configuration.py
  3. Drop support for es < 7 as per: #85
This was referenced Oct 27, 2020
Merged
Open
@turbaszek turbaszek self-assigned this Nov 8, 2020
@turbaszek
Copy link
Contributor Author

@turbaszek turbaszek commented Nov 14, 2020

Additionally when working on #94 I got the following warning. It would be good to address it:

/usr/local/lib/python3.8/site-packages/elasticsearch/connection/base.py:190: ElasticsearchDeprecationWarning: [types removal] Specifying types in document index requests is deprecated, use the typeless endpoints instead (/{index}/_doc/{id}, /{index}/_doc, or /{index}/_create/{id}).
  warnings.warn(message, category=ElasticsearchDeprecationWarning)
@turbaszek turbaszek mentioned this issue Nov 14, 2020
Closed
@skekre98
Copy link
Contributor

@skekre98 skekre98 commented Nov 14, 2020

Hi @turbaszek, I can take a look into this if it is still available?
@turbaszek
Copy link
Contributor Author

@turbaszek turbaszek commented Nov 14, 2020

@skekre98 sure! I did some changes in #94 around this. However what we need is to:

  1. Figure out where we use this class (= where we access the database)
  2. Decided what is the best approach to refactor it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turbaszek turbaszek

Labels
kind:feature
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@turbaszek @skekre98
You can’t perform that action at this time.