Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Failing to show subtitles, 0kb SRT file hindering subtitle display and new extraction attempts #3001
Labels
Comments
|
For information, for the episodes in question it takes about 1m15s to extract the SRT. I was being very optimistic before. This seems like an awful lot of time for an 18 KB file |
|
Just had the problem with another video, the same error occurs, but this time I noticed "fetching additional data" keeps on showing after the error occurs. I also see that the ffmpeg process is killed somewhere around 5 minutes. I'm guessing it's reaching some kind of timeout? For reference, this time it was an 11 GB file, Ghost.In.The.Shell.Stand.Alone.Complex.Individual.Eleven.2006.1080p.BluRay.x264-MOOVEE.mkv I'm currently doing the ffmpeg subtitle extraction command manually to see how long it takes for that file, but the speed it's doing it in is discouraging: https://i.imgur.com/t3yP44a.png Update: OK, so the subtitle extraction by doing the ffmpeg manually completed, it took well over half an hour to complete, but didn't get killed, so I'm assuming Jellyfin has some kind of timeout around 5 minutes. I'm guessing my main issue remains, that Jellyfin interprets 0kb SRT files some way that makes it not trying to re-extract the SRT file from the video and it being unable to delete the SRT file when it's locked by the ffmpeg process, but I'm also eager to find a solution to the problem that it takes so long to extract an SRT file |
|
jellyfin/MediaBrowser.MediaEncoding/Subtitles/SubtitleEncoder.cs Lines 525 to 553 in 1927d0e |
|
For reference, this is mostly a connection issue. I have since this issue was opened reconfigured by network so that my Jellyfin server has gigabit access to the place of the media library rather than 100 Mbit/s, which has helped considerably for especially tv episodes. Larger 1080p+ movie releases may still fail the 5 minute timeout for ffmpeg extraction of srt file, so while this basically comes down to infrastructure issues, it'd still be nice with better handling of the issue by Jellyfin, and possibly a increase of the 5 minute timeout or making it a setting. |
|
This issue has gone 120 days without comment. To avoid abandoned issues, it will be closed in 21 days if there are no new comments. |
|
Don't know if this is fixed or not, but I think not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Jellyfin and/or ffmpeg may fail on extracting subtitles. When this happens, a 0 KB srt file is saved but Jellyfin seems unable to remove it. Upon trying to play the video again, Jellyfin seems content that it has a 0KB SRT file, thus not playing any subtitles.
System (please complete the following information):
To Reproduce
Not sure how to produce, see additional context
Expected behavior
Jellyfin ought to
Logs
Additional context
I've had this and/or similar problems with subtitles before, but it was not until now I realized what had happened after playing around and trying to fix the issue.
I'm not sure how to reproduce, but these are the steps (as far as I can remember) for reference:
It seems ffmpeg for some reason can fail during subtitle extraction, causing Jellyfin wanting to delete the SRT file, but it still being locked by ffmpeg(?). This seems to result in the SRT file staying in place as 0KB, and at next play of the video Jellyfin is content with there being a 0kb SRT file, not trying to re-extract the subtitles.
I have to say I'm a bit confused about what is happening and why Jellyfin is extracting the subtitles at all. I also don't understand how a ~15-80kb subtitle file can take so long (20+ seconds) being written, but I guess that's ok when I know it works out in the end.
In either case, it seems more informative notifications to the user about what is happening in regards to the subtitle processing instead of "Fetching additionanl data" is needed, a check for 0kb SRT files and some kind of notification/error if the SRT file can't be deleted by Jellyfin when ffmpeg fails extraction.
Cheers