Sitelet https://web.archive.org/web/20201015155634/https://github.com/ionic-team/ionic-framework/pull/22062
Skip to content

/ ionic-framework

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vue): add ionic vue beta #22062

Merged
merged 50 commits into from Sep 10, 2020
Merged

feat(vue): add ionic vue beta #22062

merged 50 commits into from Sep 10, 2020

Conversation

@liamdebeasi
Copy link
Member

@liamdebeasi liamdebeasi commented Sep 10, 2020

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information
liamdebeasi and others added 30 commits Jul 7, 2020
@liamdebeasi
add basic ionic vue
Loading status checks…
d430147
@liamdebeasi
move target to core
Loading status checks…
6c87ee8
@liamdebeasi
update
Loading status checks…
275fe88
@liamdebeasi
update fix
1ffa9cd
@liamdebeasi
add vue3 dep:
Loading status checks…
8d2bc8f
@liamdebeasi
fix package
Loading status checks…
842a6cb
@adamdbradley
tsconfig update
Loading status checks…
0bb98b2
@adamdbradley @liamdebeasi
fix(jsx): export ionicons jsx interface
d09a263
@adamdbradley
update tsconfig
Loading status checks…
00d8cea
@liamdebeasi
Merge branch 'vue-bindings' of https://github.com/ionic-team/ionic in…
98f7ec6 
…to vue-bindings
@liamdebeasi
Merge remote-tracking branch 'origin/master' into vue-bindings
72ff371
@liamdebeasi
add vue output
Loading status checks…
467aa2c
@liamdebeasi
a few changes
Loading status checks…
1a80e4b
@liamdebeasi
generate all vmodel bindings
Loading status checks…
b26625c
@liamdebeasi
update
aacbcb1
@liamdebeasi
add global ael and rel listeners
Loading status checks…
cd66b6b
@liamdebeasi
add additional exports
Loading status checks…
167c23a
@liamdebeasi
add router base
Loading status checks…
0a23e02
@liamdebeasi
add base router
Loading status checks…
2ce53d5
@liamdebeasi
fix
Loading status checks…
28a0c98
@liamdebeasi
add router outlet
Loading status checks…
e9ce598
@liamdebeasi
add router integration to components
Loading status checks…
b8298d0
@liamdebeasi
add import
0935372
@liamdebeasi
sync with amster
Loading status checks…
e277ba5
@liamdebeasi
update types, bug fixes
Loading status checks…
e102eeb
@liamdebeasi
hardware back button support
Loading status checks…
2379912
@liamdebeasi
add back button
6021e29
@liamdebeasi
Merge remote-tracking branch 'origin/master' into vue-bindings
e902fdd
@liamdebeasi
Add back button and page component
Loading status checks…
a9388ba
@liamdebeasi
sdfsdf
Loading status checks…
6ba622f
liamdebeasi added 2 commits Aug 7, 2020
@liamdebeasi
add ion tabs and ion router outlet
Loading status checks…
eb108c5
@liamdebeasi
test
Loading status checks…
25340c8
@aparajita

This comment has been minimized.

Sign in to view
Copy link

@aparajita aparajita commented on 6ba622f Aug 9, 2020

Love the commit message! Must have been a long day. 😂
@aparajita

This comment has been minimized.

Sign in to view
Copy link

@aparajita aparajita commented on packages/vue/src/components/IonRouterOutlet.ts in eb108c5 Aug 9, 2020

@liamdebeasi I love reading your code, you're a coder after my own heart in your liberal use of vertical white space and comments!

It seems your convention (and mine too) is to surround control structures with white space. This is one place where that didn't happen.

There is an eslint rule that can enforce this btw.

This comment has been minimized.

Sign in to view
Copy link
Member Author

@liamdebeasi liamdebeasi replied Aug 10, 2020

Thanks! Do you recall the name of the eslint rule? I can add it to my branch.

This comment has been minimized.

Sign in to view
Copy link

@aparajita aparajita replied Aug 10, 2020

Here's my config, I think it conforms to your conventions:

    'padding-line-between-statements': [
      'error',
      { blankLine: 'always', prev: 'block-like', next: '*' },
      { blankLine: 'always', prev: 'break', next: '*' },
      { blankLine: 'always', prev: '*', next: 'class' },
      { blankLine: 'always', prev: '*', next: 'default' },
      { blankLine: 'always', prev: '*', next: 'do' },
      { blankLine: 'always', prev: '*', next: 'for' },
      { blankLine: 'always', prev: '*', next: 'function' },
      { blankLine: 'always', prev: '*', next: 'if' },
      { blankLine: 'always', prev: '*', next: 'iife' },
      { blankLine: 'always', prev: '*', next: 'switch' },
      { blankLine: 'always', prev: '*', next: 'try' },
      { blankLine: 'always', prev: '*', next: 'while' }
    ],
liamdebeasi added 14 commits Aug 13, 2020
@liamdebeasi
add tabs components
Loading status checks…
66136a3
@liamdebeasi
updates
Loading status checks…
6df72ae
@liamdebeasi
add components, fix back button behavior
Loading status checks…
d1ca172
@liamdebeasi
ugh
Loading status checks…
d0e0924
@liamdebeasi
Sync with master
Loading status checks…
fa76cc6
@liamdebeasi
add lifecycle events
Loading status checks…
aeeadfa
@liamdebeasi
remove comments for beta
Loading status checks…
1e37b88
@liamdebeasi
add tabs
Loading status checks…
395a6be
@liamdebeasi
update deps
Loading status checks…
faa6736
@liamdebeasi
bug fixes
Loading status checks…
6ec8863
@liamdebeasi
fix tabs
a6d6d90
@liamdebeasi
fix comp cache issue
Loading status checks…
949031e
@liamdebeasi
allow users to nest pages without needing additional router outlets
Loading status checks…
0a58ae9
@liamdebeasi
fix can go back
Loading status checks…
b3f8314
@aparajita

This comment has been minimized.

Sign in to view
Copy link

@aparajita aparajita commented on 0a58ae9 Sep 7, 2020

Go, Liam, go! 😁

While you're thinking about tabs and transitions, in the 0.9 version transitions to a page with ion-tabs don't work. Is that working in your dev version?
liamdebeasi added 3 commits Sep 8, 2020
@liamdebeasi
update route config after talking with eduardo
Loading status checks…
be01184
@liamdebeasi
chore(): fix build (#22058)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0d41d75
@liamdebeasi
sync with master
Loading status checks…
24f93f5
@liamdebeasi
Copy link
Member Author

@liamdebeasi liamdebeasi commented Sep 10, 2020

@aparajita Transitions to a page with ion-tabs should be working now! You can do something like this:

<template>
  <ion-page>
    <ion-content>
      <ion-tabs>
        <ion-tab-bar slot="bottom">
          <ion-tab-button tab="tab1" href="/tabs/tab1">
            <ion-icon :icon="calendar" />
            <ion-label>Calendar</ion-label>
          </ion-tab-button>
          
          <ion-tab-button tab="tab2" href="/tabs/tab2">
            <ion-icon :icon="cog" />
            <ion-label>Settings</ion-label>
          </ion-tab-button>
        </ion-tab-bar>
      </ion-tabs>
    </ion-content>
  </ion-page>
</template>
@liamdebeasi
update
Loading status checks…
1a3e0ac
@liamdebeasi liamdebeasi merged commit 5ffa65f into ionic-vue Sep 10, 2020
2 checks passed
2 checks passed
build Workflow: build
Details
screenshot Screenshot
Details
@liamdebeasi liamdebeasi deleted the vue-bindings branch Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@liamdebeasi @aparajita @adamdbradley
You can’t perform that action at this time.