Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Doc: Relative links broken under Thanos section #3523
Comments
|
can I work on this issue? |
|
@DARK-art108 please, go ahead :) |
|
@soniasingla could you please explain to me a little bit about the changes need to made in docs, I am not getting much from the above issues headline :) |
|
I was trying to fix this myself before submitting as an issue, spent some time trying to figure out what is happening. I'm not really used to playing with netlify so @DARK-art108 please do go ahead. I'll share some of the things that I found, if that saves your time :) If you go to the page that I linked, relative links like the architecture overview, or the links in h3 section header would appear broken. For instance, this link is broken, because it's href-ing https://thanos.io/v0.17/thanos/components/sidecar.md instead of https://thanos.io/v0.17/components/sidecar.md . If you go on GitHub (https://github.com/thanos-io/thanos/blob/master/docs/quick-tutorial.md), they are all normal. I was suspecting that this issue is related to this commit |
The relative links on the webpage documentation under Thanos section appear to be broken.
In terms of git, I'm referring to the files matching
docs/*.md(notdocs/**/*.md)This is because of the trailing
/character in the web urls (i.e. https://thanos.io/v0.17/thanos/quick-tutorial.md/).It's tricky to apply an easy fix when considering both the webpage and GitHub.