Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Added efficiency improvement to get_installation #191
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
I've been using this project as a template for my own github app and it has been really helpful, so thank you.
When looking through I did notice one slight enhancement - github has an endpoint to get the installation directly given a user which is easier than getting every installation of the app and looping through them all to find the user.
Hopefully this is helpful, I have tested it on my own app and the two functions return exactly the same data. I couldn't think of an easy way to add a test for this but if anyone can suggest one then I can add it in.