Sitelet https://web.archive.org/web/20260125030643/https://github.com/angular/angular-cli/pull/15345
Skip to content

refactor(@angular-devkit/core): convert json schema registry to use async/await #15345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alan-agius4 merged 5 commits into from
Feb 4, 2021
Merged

refactor(@angular-devkit/core): convert json schema registry to use async/await #15345

alan-agius4 merged 5 commits into from
Feb 4, 2021

Conversation

@clydin
Copy link
Member

@clydin clydin commented Aug 15, 2019

No description provided.

@clydin clydin added the target: major This PR is targeted for the next major release label Aug 15, 2019
@clydin clydin force-pushed the json-schema-async branch from 75254bc to c3e85d8 Compare August 15, 2019 16:56
@clydin clydin force-pushed the json-schema-async branch 2 times, most recently from 0ee1db5 to 639fe3e Compare August 18, 2019 00:17
@clydin clydin force-pushed the json-schema-async branch from f643258 to 46415ca Compare October 16, 2019 15:31
@clydin clydin force-pushed the json-schema-async branch from 46415ca to e431f00 Compare January 9, 2020 16:49
@clydin clydin force-pushed the json-schema-async branch 3 times, most recently from feda371 to 38e1a00 Compare October 8, 2020 19:21
@clydin clydin requested a review from alan-agius4 November 18, 2020 18:06
@alan-agius4 alan-agius4 added target: minor This PR is targeted for the next minor release and removed target: major This PR is targeted for the next major release labels Dec 11, 2020
alan-agius4
alan-agius4 reviewed Dec 11, 2020
View reviewed changes
alan-agius4
alan-agius4 reviewed Dec 11, 2020
View reviewed changes
alan-agius4
alan-agius4 approved these changes Dec 11, 2020
View reviewed changes
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great as it removes a lot of unneeded RXJS complexity.

Just 2 comments, otherwise LGTM.

@alan-agius4 alan-agius4 added target: major This PR is targeted for the next major release action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed target: minor This PR is targeted for the next minor release labels Dec 11, 2020
@clydin clydin force-pushed the json-schema-async branch from 86e186e to 577ec30 Compare January 19, 2021 01:08
@clydin clydin removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jan 19, 2021
@clydin clydin added the action: merge The PR is ready for merge by the caretaker label Feb 4, 2021
@alan-agius4 alan-agius4 merged commit a986d8a into angular:master Feb 4, 2021
@clydin clydin deleted the json-schema-async branch February 4, 2021 10:58
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Mar 7, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alan-agius4 alan-agius4 alan-agius4 approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@clydin @alan-agius4 @googlebot