python:3.8 - Added comment for enum cmp_op in generate_opcode_h.py#23585
Closed
ateffal wants to merge 1 commit into
Closed
python:3.8 - Added comment for enum cmp_op in generate_opcode_h.py#23585ateffal wants to merge 1 commit into
ateffal wants to merge 1 commit into
Conversation
Author
|
Sorry, I'm new to this. |
Author
|
What I'm supposed to do about the 4 failing tests ? |
|
This PR is stale because it has been open for 30 days with no activity. |
Contributor
|
Closing this stale backport as the 3.8 is nearing to security-fix only mode. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added comment for enum cmp_op in generate_opcode_h.py :
/*
Store comparaison operators in an enum.
give each of them a new name : PY_OP --> PYCmp_OP.
PyCmp_LT <- PY_LT : Less Than (<)
PyCmp_LE <- PY_LE : Less or Equal than (<=)
PyCmp_EQ <- PY_EQ : EQual (==)
PyCmp_NE <- PY_NE : Not Equal (!=)
PyCmp_GT <- PY_GT : Greater Than (>)
PyCmp_GE <- PY_GE : Greater or Equal than (>=)
PyCmp_IN : a is IN sequence b (a in b)
PyCmp_NOT_IN : a is NOT IN sequence b (a not in b)
PyCmp_IS : a IS b (a is b)
PyCmp_IS_NOT : a IS NOT b (a is not b)
PyCmp_EXC_MATCH : EXCact MATCH of exception a and b
PyCmp_BAD : BAD operator : not suppoerted.
This enum is used by function cmpop in compile.c to map
elements from cmpop_ty enum defined in Python-ast.h
*/
enum cmp_op {PyCmp_LT=Py_LT, PyCmp_LE=Py_LE, PyCmp_EQ=Py_EQ, PyCmp_NE=Py_NE,
PyCmp_GT=Py_GT, PyCmp_GE=Py_GE, PyCmp_IN, PyCmp_NOT_IN,
PyCmp_IS, PyCmp_IS_NOT, PyCmp_EXC_MATCH, PyCmp_BAD};