Sitelet https://web.archive.org/web/20260522181212/https://github.com/python/cpython/pull/23585
Skip to content

python:3.8 - Added comment for enum cmp_op in generate_opcode_h.py#23585

Closed
ateffal wants to merge 1 commit into
python:3.8from
ateffal:doc-contrib
Closed

python:3.8 - Added comment for enum cmp_op in generate_opcode_h.py#23585
ateffal wants to merge 1 commit into
python:3.8from
ateffal:doc-contrib

Conversation

@ateffal
Copy link
Copy Markdown

@ateffal ateffal commented Dec 1, 2020

Added comment for enum cmp_op in generate_opcode_h.py :

/*
Store comparaison operators in an enum.
give each of them a new name : PY_OP --> PYCmp_OP.
PyCmp_LT <- PY_LT : Less Than (<)
PyCmp_LE <- PY_LE : Less or Equal than (<=)
PyCmp_EQ <- PY_EQ : EQual (==)
PyCmp_NE <- PY_NE : Not Equal (!=)
PyCmp_GT <- PY_GT : Greater Than (>)
PyCmp_GE <- PY_GE : Greater or Equal than (>=)
PyCmp_IN : a is IN sequence b (a in b)
PyCmp_NOT_IN : a is NOT IN sequence b (a not in b)
PyCmp_IS : a IS b (a is b)
PyCmp_IS_NOT : a IS NOT b (a is not b)
PyCmp_EXC_MATCH : EXCact MATCH of exception a and b
PyCmp_BAD : BAD operator : not suppoerted.

This enum is used by function cmpop in compile.c to map
elements from cmpop_ty enum defined in Python-ast.h

*/

enum cmp_op {PyCmp_LT=Py_LT, PyCmp_LE=Py_LE, PyCmp_EQ=Py_EQ, PyCmp_NE=Py_NE,
PyCmp_GT=Py_GT, PyCmp_GE=Py_GE, PyCmp_IN, PyCmp_NOT_IN,
PyCmp_IS, PyCmp_IS_NOT, PyCmp_EXC_MATCH, PyCmp_BAD};

@ateffal
Copy link
Copy Markdown
Author

ateffal commented Dec 11, 2020

Sorry, I'm new to this.
Should I do something for "No issue # in title or "skip issue" label found" ? " — Not a valid maintenance branch PR title."?

@ateffal
Copy link
Copy Markdown
Author

ateffal commented Dec 12, 2020

What I'm supposed to do about the 4 failing tests ?

@github-actions
Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Jan 12, 2021
@ambv
Copy link
Copy Markdown
Contributor

ambv commented Apr 26, 2021

Closing this stale backport as the 3.8 is nearing to security-fix only mode.

@ambv ambv closed this Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review stale Stale PR or inactive for long period of time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants