Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Card respects surface color #71380
Card respects surface color #71380
Conversation
|
@shihaohong would be great if you could review my PR |
|
This would be a pretty breaking change for theming /cc @HansMuller, who's been working a lot more with themes lately than I have, but my suspicion is that we should not making this change. |
Description
Existing Behaviour
Card takes default white color even if surface color is not-null.
Modified Behaviour
If surface color is given then card respects the surface color else it takes default white color.
Runnable Code Snippets
MyApp.dart
Related Issues
fixes #28783
Tests
I added the following tests:
ColorScheme.light().copyWith(), but this implementation remains true forColorScheme.dark(),ColorScheme(). Should I write test for all of them?Checklist
///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change