Sitelet https://web.archive.org/web/20210926164605/https://github.com/nodejs/node/pull/36296
Skip to content

/ node Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readline: refactor to use more primordials #36296

Closed
wants to merge 1 commit into from
Closed

readline: refactor to use more primordials #36296

wants to merge 1 commit into from

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 27, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@aduh95
readline: refactor to use more primordials
4e9b2a6
Trott
Trott approved these changes Nov 29, 2020
View changes
@nodejs-github-bot

This comment has been hidden.

Sign in to view
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Nov 30, 2020 •
edited by aduh95

CI: https://ci.nodejs.org/job/node-test-pull-request/34633/ ✅

@github-actions
Copy link

@github-actions github-actions bot commented Dec 4, 2020

Landed in e074bee...ed6e71a

@github-actions github-actions bot closed this Dec 4, 2020
nodejs-github-bot added a commit that referenced this issue Dec 4, 2020
@aduh95 @nodejs-github-bot
readline: refactor to use more primordials
ed6e71a 
PR-URL: #36296
Reviewed-By: Rich Trott <rtrott@gmail.com>
@aduh95 aduh95 deleted the readline-primordials branch Dec 4, 2020
danielleadams added a commit that referenced this issue Dec 7, 2020
@aduh95 @danielleadams
readline: refactor to use more primordials
b885409 
PR-URL: #36296
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request Dec 7, 2020
Merged
cjihrig added a commit to cjihrig/node that referenced this issue Dec 8, 2020
@aduh95 @cjihrig
readline: refactor to use more primordials
31d6721 
PR-URL: nodejs#36296
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos added a commit that referenced this issue May 16, 2021
@aduh95 @targos
readline: refactor to use more primordials
efbec9d 
PR-URL: #36296
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Jun 6, 2021
Merged
targos added a commit that referenced this issue Jun 11, 2021
@aduh95 @targos
readline: refactor to use more primordials
b5b8a99 
PR-URL: #36296
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott

Assignees
No one assigned
Labels
author ready readline
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@aduh95 @nodejs-github-bot @Trott