Sitelet https://web.archive.org/web/20200916181314/https://github.com/nodegit/nodegit/pull/1506
Skip to content

/ nodegit

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the promisify-node package #1506

Open
wants to merge 1 commit into
base: master
from
Open

Bump the promisify-node package #1506

wants to merge 1 commit into from

Conversation

@tbranyen
Copy link
Member

tbranyen commented Jun 5, 2018

Fixes Node 10 issues.
@tbranyen
Copy link
Member Author

tbranyen commented Jun 5, 2018

NPM is having consistency issues ATM. Published 0.5.0, but NPM reports 0.4.0 as latest. I'll try again later in the day.
@tbranyen
Bump the promisify-node package
Loading status checks…
0f87857
@tbranyen tbranyen force-pushed the bump-promisify-node branch from 3930624 to 0f87857 Jun 5, 2018
@tbranyen
Copy link
Member Author

tbranyen commented Jun 5, 2018

Looks like I broke some tests with the latest promisify-node. I'll work on addressing these, once NodeGit builds on Node 10.
@Croydon Croydon mentioned this pull request Jul 8, 2018
Closed
@Croydon Croydon mentioned this pull request Jul 26, 2018
Merged
@Croydon
Copy link
Contributor

Croydon commented Sep 29, 2018

Is this commit helping? 55e5a35

However, be careful, this might cause a freeze in the tests with Node 6 on Windows as I have experienced in #1519
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@tbranyen @Croydon
You can’t perform that action at this time.