Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
TST: any_* fixtures are confusingly named #38017
Comments
|
makes sense |
|
Proposed naming seems to make sense (note I removed the 1.2 milestone, since I don't think this is in any way important for the release? So we can use the milestone to track release critical issues) |
|
@jreback I would love to work on this issue. If you agree then I will start working on it. |
the naming on the any_* fixtures in
pandas/conftest.pyis pretty confusingany_int_dtype(numpy only)any_int_nullable_dtype(EA only)any_numeric_dtypeboth numpy & EAany_real_dtypeboth numpy int & floatsint_dtypesigned numpy intsfor example
so we need dtypes that are numpy_only and EA only and numpy + EA both for ints & floats
would propose something like
any_int_numpy_dtypeany_int_ea_dtypeany_int_dtype-> both numpy + easame for float
then
any_numeric_nump_dtypeany_numeric_ea_dtypefor float + int
which means we rename
sint_dtype->any_signed_int_numpy_dtypeI think this would require a PR to organize, a PR to create new names & fix everything.