Sitelet https://web.archive.org/web/20201127142740/https://github.com/pandas-dev/pandas/issues/38017
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: any_* fixtures are confusingly named #38017

Open
jreback opened this issue Nov 23, 2020 · 4 comments
Open

TST: any_* fixtures are confusingly named #38017

jreback opened this issue Nov 23, 2020 · 4 comments

Comments

@jreback
Copy link
Contributor

@jreback jreback commented Nov 23, 2020

the naming on the any_* fixtures in pandas/conftest.py is pretty confusing

  • any_int_dtype (numpy only)
  • any_int_nullable_dtype (EA only)
  • any_numeric_dtype both numpy & EA
  • any_real_dtype both numpy int & float
  • sint_dtype signed numpy ints

for example

so we need dtypes that are numpy_only and EA only and numpy + EA both for ints & floats

would propose something like

any_int_numpy_dtype
any_int_ea_dtype
any_int_dtype -> both numpy + ea

same for float

then

any_numeric_nump_dtype
any_numeric_ea_dtype

for float + int

which means we rename
sint_dtype -> any_signed_int_numpy_dtype

I think this would require a PR to organize, a PR to create new names & fix everything.

@jreback jreback added this to the 1.2 milestone Nov 23, 2020
@jreback
Copy link
Contributor Author

@jreback jreback commented Nov 23, 2020

@jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Nov 23, 2020

makes sense

@jorisvandenbossche jorisvandenbossche removed this from the 1.2 milestone Nov 23, 2020
@jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche commented Nov 23, 2020

Proposed naming seems to make sense

(note I removed the 1.2 milestone, since I don't think this is in any way important for the release? So we can use the milestone to track release critical issues)

@jreback jreback added this to the Contributions Welcome milestone Nov 23, 2020
@rkc007
Copy link

@rkc007 rkc007 commented Nov 23, 2020

@jreback I would love to work on this issue. If you agree then I will start working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.