Sitelet https://web.archive.org/web/20260215041753/https://github.com/TheAlgorithms/Python/pull/2760
Skip to content

Added algorithm for binary tree right view#2760

Closed
susmith98 wants to merge 3 commits intoTheAlgorithms:masterfrom
susmith98:right_view
Closed

Added algorithm for binary tree right view#2760
susmith98 wants to merge 3 commits intoTheAlgorithms:masterfrom
susmith98:right_view

Conversation

@susmith98
Copy link
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@TravisBuddy
Copy link

Travis tests have failed

Hey @susmith98,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: c91bc4d0-0651-11eb-a99f-97db2ffc4a93

@susmith98
Copy link
Contributor Author

Hey @cclauss / @poyea :). Can you please review and merge this PR? Please let me know if any changes are to be made.

@poyea
Copy link
Member

poyea commented Oct 5, 2020

How about combine this with #2757 and #2733?

@susmith98
Copy link
Contributor Author

susmith98 commented Oct 5, 2020 •

Thanks for the response @poyea. In contribution guidelines, it is recommended to have different PR's for different Algorithms. Even though this Algorithm is similar to those Algorithms (#2757 and #2733), still this need to be a separate file right?

@susmith98
Copy link
Contributor Author

Hey @cclauss @poyea, Any remarks regarding the above comment?

@poyea
Copy link
Member

poyea commented Oct 6, 2020

But I find these three are very similar... I'll wait for other's comments ATM.

@susmith98
Copy link
Contributor Author

@cclauss Can you please review and merge this?

@cclauss
Copy link
Member

cclauss commented Oct 9, 2020

@poyea is correct. One file with 3 related functions.

@cclauss
Copy link
Member

cclauss commented Oct 9, 2020

Please do not @mention maintainers. This repo has almost 300 open PRs.

@stale
Copy link

stale bot commented Nov 21, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label Nov 21, 2020
@stale
Copy link

stale bot commented Dec 10, 2020

Please reopen this pull request once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to seek help from our Gitter or ping one of the reviewers. Thank you for your contributions!

@stale stale bot closed this Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale Used to mark an issue or pull request stale.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants