Hey @Mohitkumar6122,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 7bc852f0-fbe5-11ea-a343-ef792cdaf85e

Hey @Mohitkumar6122,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 240b5760-fbef-11ea-a343-ef792cdaf85e

How to remove trailing whitespaces warning in PEP8 format ?

Hey @Mohitkumar6122,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 4146f1c0-fbf1-11ea-a343-ef792cdaf85e

Hey @Mohitkumar6122,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: e9f9a190-fbf2-11ea-a343-ef792cdaf85e

Hey @Mohitkumar6122,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 983a8c60-fbf3-11ea-a343-ef792cdaf85e

Finaly after 6 builds it passed xD

https://github.com/TheAlgorithms/Python/tree/master/scheduling is the place for scheduling algorithms.

https://github.com/TheAlgorithms/Python/tree/master/scheduling is the place for scheduling algorithms.

ohh my bad, i just pasted it into greedy i will move it to scheduling ASAP.

could you review my PR @cclauss

Try to bind as few things to your objects as you can. x will always be faster and easier to understand (and debug) than my_object.x.

Try to bind as few things to your objects as you can. x will always be faster and easier to understand (and debug) than my_object.x.

thanks for the suggestion , i will keep it in mind.

Hey @Mohitkumar6122,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 4c008d90-fcbb-11ea-a56a-67316b5b87cd

Hey @Mohitkumar6122,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: c220e100-fcbb-11ea-a56a-67316b5b87cd

Travis tests have failed

Hey @Mohitkumar6122,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 0beee2d0-fcfa-11ea-a56a-67316b5b87cd

@cclauss could you review my PR ?

Create a Job class

I hope these changes help to clarify...

I have rearranged the code in a way that will BREAK THE TESTS. I make this clearer, we will have a Job class and will remove the Schedule class and replace it with functions. Let's keep the Job class super simple. Its only goal is to carry around the deadline and profit for each Job so that we no longer move around separate lists of ints.

With these changes, each of our three main functions takes in a list of jobs. We should keep things flexible so that we could create test_jobs_two and run it thru all functions and get different results.

Hey @Mohitkumar6122,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: d78a7b90-ffd7-11ea-9882-0125ab0f75bf

Create a Job class

I hope these changes help to clarify...

I have rearranged the code in a way that will BREAK THE TESTS. I make this clearer, we will have a Job class and will remove the Schedule class and replace it with functions. Let's keep the Job class super simple. Its only goal is to carry around the deadline and profit for each Job so that we no longer move around separate lists of ints.

With these changes, each of our three main functions takes in a list of jobs. We should keep things flexible so that we could create test_jobs_two and run it thru all functions and get different results.

your changes made code super easy and understandable but problem is that it isn't running any more 😟

problem is that it isn't running anymore

Yes... I do not understand the algorithm so you will have to make it work again with the Jobs class and the function signatures that I provided.

problem is that it isn't running anymore

Yes... I do not understand the algorithm so you will have to make it work again with the Jobs class and the function signatures that I provided.

sure i will work on it ASAP but my exams are coming so maybe i will start working on it after 2 weeks 😄

1 E302 expected 2 blank lines, found 1
1 E305 expected 2 blank lines after class or function definition, found 1
54 F821 undefined name 'self'

The trouble starts with the schedule function on line 49 and continues all the way down.
It seems like the functions schedule and is_feasible were meant to be class methods?
However I don't see self.x, self.j or self.k included in the constructor method of Job.
I guess those were left over from the earlier Schedule class?
If the two functions were NOT meant to be class methods for Job they need to be rewritten completely, with any references to self removed.

Yes @spamegg1 that was already discussed in the comments above.

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Please reopen this pull request once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to seek help from our Gitter or ping one of the reviewers. Thank you for your contributions!