Remove jdk.charset module dependency for spreadsheets generation #198
Conversation
|
The build failure looks unrelated to my changes |
If you get that warning, your javac is not running in Java 9+ mode. I thought I've changed the build in a way, that it recognizes the JVM. So it uses classpath mode for Java 8 and modulepath mode for Java 9+. if this doesn't work for your environment, I need to investigate what's the difference there ... with your help. anyway with this warning and your proposed change, I think the tests are running in classpath mode and therefore aren't significant ... |
My build using Java 8 says: The build machines say the Ant version is: This is a message from current Ant that is not present in that old Ant An Ant update on the build machines should fix it Edit: My Ant is |
Just for clarifying, I don't get that error, in my machine the build is ok. The Travis CI display that error, see my previous message about the Travis CI using and older version of Ant than me |
|
@robmv could you merge the poi trunk to your MR? I think a recent change could help with the travis build. |
Move double byte charset utility code to scratchpad...hwpf that is the only code that currently requires them. This allows using spreadsheet related code without pulling jdk.charset to custom built JREs using jlink.
|
@pjfanning Done. Please note that I had to remove I wonder if the reason compiled |
Move double byte charset utility code to scratchpad...hwpf that is the only code that currently requires them. This allows using spreadsheet related code without pulling jdk.charset to custom built JREs using jlink.