Sitelet https://web.archive.org/web/20200917220541/https://github.com/nodejs/docker-node/issues/1303
Skip to content

/ docker-node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

12.18.3 breaks with Docker-in-Docker #1303

Open
CptDaniel opened this issue Jul 29, 2020 · 2 comments
Open

12.18.3 breaks with Docker-in-Docker #1303

CptDaniel opened this issue Jul 29, 2020 · 2 comments

Comments

@CptDaniel
Copy link

@CptDaniel CptDaniel commented Jul 29, 2020 •
edited

We are building our software on Gitlab in a Runner with docker:19.03-dind running as our docker daemon. All of our builds use node:12-alpine as base image and since yesterday we get this error in one of our projects during npm install:

SyntaxError: Error parsing /home/node/.npm/_cacache/tmp/git-clone-cceb0072/node_modules/fs-extra/package.json: Unexpected token , in JSON at position 2553

Is this fixable without pinning the version to 12.18.2 or is this an issue with fs-extra in particular?

Thanks.
@AlecTroemel
Copy link

@AlecTroemel AlecTroemel commented Jul 30, 2020

I'm experiencing this same error for different packages. For me it happens when running tests. I think a dependency of a dependency of nyc is the culprit, and fs-extra is no where to be seen in the call-stack. That to say this may be more general then just docker-in-docker. Here's the full(ish) error

SyntaxError: Error parsing /builds/root/PROJECT_PATH/node_modules/isobject/package.json: Unexpected token , in JSON at position 1496
    at JSON.parse (<anonymous>)
    at require (internal/modules/cjs/helpers.js:72:18)
    at Object.<anonymous> (/builds/root/PROJECT_PATH/node_modules/is-plain-object/index.js:10:16)
    at Module._compile (internal/modules/cjs/loader.js:1137:30)
    at Module.replacementCompile (/builds/root/PROJECT_PATH/node_modules/nyc/node_modules/append-transform/index.js:58:13) {
  path: '/builds/root/PROJECT_PATHi/node_modules/isobject/package.json'

pinning to version 12.18.2 fixes it for me as well
@cabbiepete
Copy link

@cabbiepete cabbiepete commented Aug 3, 2020

Same also was happening on all our GitHub action nodes until we locked them at 12.18.2 as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@cabbiepete @CptDaniel @AlecTroemel
You can’t perform that action at this time.