Sitelet https://web.archive.org/web/20201119230423/https://github.com/jsonld-java/jsonld-java/pull/284
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current state of 1.1 development #284

Merged
merged 7 commits into from Jul 9, 2020
Merged

Current state of 1.1 development #284

merged 7 commits into from Jul 9, 2020

Conversation

@fsteeg
Copy link
Member

@fsteeg fsteeg commented Apr 28, 2020

As announced in #277 (comment), this PR contains the current functional changes for 1.1.

It also contains comments by @gkellogg from gkellogg@53aa216 (thanks!)

The diff on core/reports/json-ld-api-tests-skip shows the progress compared to the 1.1-tests branch (currently 94 removed lines, i.e. 94 additional passing tests). See individual commits for details on which code changes make which tests pass. Open the URLs for test details.

This is the report summary for 1.1 compliance with the current code (see 2318376):

tests pass
Compaction 101/238 (42.4%)
Expansion 124/366 (33.9%)
Flattening 45/55 (81.8%)
Framing 26/89 (29.2%)
HTML 3/49 (6.1%)
Remote document 3/18 (16.7%)
Transform JSON-LD to RDF 178/442 (40.3%)
Transform RDF to JSON-LD 39/51 (76.5%)

The base for this PR is set to 1.1-tests for a reviewable diff (i.e. merge into master after #283).

fsteeg and others added 7 commits Oct 25, 2019
- be more verbose in some error messages
- add some more comments pointing to the specs
- add a blank node condition according to spec 16.4
Focusing on expansion and context/term processing
@fsteeg fsteeg requested a review from dr0i Apr 28, 2020
@coveralls
Copy link

@coveralls coveralls commented Apr 28, 2020

Coverage Status

Coverage increased (+0.04%) to 90.37% when pulling b6ba9e8 on 1.1 into 53470d6 on 1.1-tests.

@dr0i
dr0i approved these changes Apr 28, 2020
@fsteeg
Copy link
Member Author

@fsteeg fsteeg commented Jul 3, 2020

I just discovered that there is a new Java implementation for JSON-LD 1.1, titanium-json-ld: https://github.com/filip26/titanium-json-ld. It is linked from https://json-ld.org/ and included in the conformance report at https://w3c.github.io/json-ld-api/reports/. Given the amount of work still required here, and the level of conformance already achieved by titanium-json-ld, I'm wondering if it actually makes sense to continue our effort here.

@ansell
Copy link
Member

@ansell ansell commented Jul 9, 2020

I have not had time to put into this project recently. If the JSON-LD 1.1 changes are not progressing well, then that may be an option. I am merging this into the 1.1 branch based on Travis passing.

@ansell ansell merged commit 3c8039f into 1.1-tests Jul 9, 2020
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.04%) to 90.37%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.