Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 50 million developers.
Sign up
Pinned
5,593 contributions in the last year
Activity overview
Contribution activity
November 2020
Created 49 commits in 2 repositories
Created a pull request in dotnet/roslyn that received 2 comments
Ensure we always get up to date diagnostics when getting pull diagnostics.
This splits our LSP diagnostics into two effective 'worlds'. A client can get diagnostics for open documents (specifically, documents they sent 'di…
+394
−134
•
2
comments
Opened 9 other pull requests in 2 repositories
dotnet/roslyn
8
merged
- fix 'remove unnecessary cast' when doing bitwise ops on unsigned values.
- Fix split comment exporting for VB.
- Make each request id for doc and workspace diagnostics unique.
- Don't offer use-compound-assignment with implicit object creation.
- Do not convert an unconstrained generic to a nullable struct.
- Further tweak rendering of inline hints
- Disable workspace diagnostics for the razor client.
- Add feature to remove unnecessary discards.
dotnet/docs
1
merged
Reviewed 36 pull requests in 1 repository
dotnet/roslyn 36 pull requests
- Reuse LSP solutions if they don't need re-forking
- Use lazy cancellation in RemoteEndPoint.InvokeAsync<T>
- Overwrite xunit's app domain handling to not call AppDomain.Unload
- Fix split comment exporting for VB.
- Add muscle-memory tests for braces
- Use VisualStudioTestCompositions.LanguageServices in F1HelpTests
- Enable caching of semantic models during generator runs
- Use TemporaryArray<T> instead of ArrayBuilder<T>
- [Refactoring] ConvertConcatenationToInterpolatedString: Support inlineing of other interpolated strings
- [LSP] Fix FAR namespace bug + re-enable FAR tests
- Initial stubs for an LSIF generator that runs as part of the normal compilation pass.
- Refactor BlockStructure service and providers
- Implement IVsEditorFactory4
- Support abstract methods and records in complete statement command
- Enable LSP pull model diagnostic for XAML.
- Don't offer "introduce local constant" for constants
- Don't offer to use an object initializer in a using declaration
- Cache RegexPatternDetector per compilation
- Add outlining support to LsifGenerator
- Intellisense for cast, indexers and operators
- Fix extract local function crash
- Increase unexpected delay timeout
- Use lazy cancellation in RemoteEndPoint.InvokeAsync<T>
- Fix MemberNames API for records
- Completion for enum members in is expressions
- Some pull request reviews not shown.
Created an issue in dotnet/csharplang that received 21 comments
Recursive property pattern allows reference to same property multiple times.
Example: void M(string s) { if (s is { Length: 0, Length: var v }) { } } This honestly feels strange to me and potentially a bug oversight. If a bu…
21
comments
Opened 3 other issues in 2 repositories
Answered 4 discussions in 2 repositories
dotnet/csharplang
dotnet/csharplang
dotnet/roslyn
dotnet/roslyn