Create your own GitHub profile
Sign up for your own profile on GitHub, the best place to host code, manage projects, and build software alongside 50 million developers.
Sign upPinned
2,019 contributions in the last year
Activity overview
Contributed to
microsoft/TypeScript,
DefinitelyTyped/DefinitelyTyped,
microsoft/DefinitelyTyped-tools
and 5 other
repositories
Contribution activity
November 2020
Created 35 commits in 8 repositories
Created a pull request in microsoft/TypeScript that received 9 comments
Improve uncalled function checks
Fixes #41586 Fixes #41588 For binary expressions, if the immediate parent is an IfStatement, then check the body of the if statement. I didn't wa…
+338
−125
•
9
comments
Opened 18 other pull requests in 4 repositories
microsoft/DefinitelyTyped-tools
6
merged
1
closed
DefinitelyTyped/DefinitelyTyped
5
merged
microsoft/TypeScript
4
merged
microsoft/TypeScript-repos-automation
2
merged
Reviewed 64 pull requests in 7 repositories
DefinitelyTyped/DefinitelyTyped 34 pull requests
- [README] Update references to DefinitelyTyped-tools
- Update definitions for bindings package
- [echarts] #42212 Add Color type
- update(date-arithmetic): version 4 updates
- add @types/bitcore-lib-cash
- Add types for knex-cleaner
- Update knuddels-userapps-api
- [README] Add escapes missed in #49636
- [avoscloud-sdk] Remove types
- [jasmine] Make Promise more lax.
- Passport auth token
- Add types for tuya-panel-kit
- Update fhir-kit-client (and fhir)
- Improve tests documentation
- Add is-utf8 types
- update remarkable types for 2.0
- [node-mongodb-fixtures] Create type definition for node-mongodb-fixtures
- Add type definitions for play-sound
- Add gapi.client.firebasedatabase
- [react-redux] connect now preserves discriminated unions
- Initial commit for VisualNE, a visual node editor.
- [README] Move section to match table of contents
- Add type definition for 'hsl-to-hex' module
- Add typings for markdown-it-highlightjs
- gapi.client.* update for #49235
- Some pull request reviews not shown.
microsoft/TypeScript 23 pull requests
- Fix import tracker for dynamic import
- Remove obsolete go-to-definition code after CommonJS alias changes
- fix(37539): Parameter not renamed in JSDoc if it's inside non-prototype-based JS class
- feat(41216): JSDoc not retained across default re-export
- fix(41194): Sort import: Uncoditionally removes JSX Fragment reference
- fix(41268): Replace leading tabs in diagnostic code with spaces
- fix(41240): Support emitting numerics with separators as-is in target: esnext
- fix(41405): No 'async' conversion hint when using reference to class method as parameter to .then()
- feat(31388): Destructuring array, ability to explicitly tell the variable is unused
- Fix show deprecated suggestion for alias
- Add target: ES2021
- Allow type-only imports on ImportEqualsDeclarations
- IntelliSense doc string.replace typo
- fix(41492): Uncalled function checks need rhs-used-exemption for binary expression
- Unused Identifier codefix better understands constructors and methods
- 🤖 User test baselines have changed for refs/heads/master
- Fix crash on attempting to suggest a ts import for a synthetic js resolution
- fixes microsoft/TypeScript#41286
- 🤖 User test baselines have changed for refs/heads/master
- fix(40632): Don't emit abstract members
- fix(40257): Remove type parameters quick fix forgets the trailing >
- fix(39858): "Convert to async function" refactor generates invalid code with imported functions
- fix(40042): Convert to async function with decorator
microsoft/DefinitelyTyped-tools 3 pull requests
microsoft/dtslint 1 pull request
sandersn/downlevel-dts 1 pull request
microsoft/TypeScript-repos-automation 1 pull request
microsoft/TypeScript-Website 1 pull request
Created an issue in microsoft/TypeScript that received 9 comments
Uncalled-function error with function check in binary expression misses usage in body
declare var f: () => void declare var b: boolean if (f && b) { f() } Expected behavior: No error Actual behavior: Error: "Did you mean to call 'f'?"
9
comments
Opened 9 other issues in 2 repositories
microsoft/TypeScript
5
open
3
closed
- remove-unused-identifier codefix-all fails to remove ++
- remove-unused-identifier codefix-all doesn't remove redundant `var`
- Uncalled-function check misses usage of complex property access
- fixUnusedIdentifier asserts, mayDeleteParameter was called on FunctionType
- Unused declaration codefix doesn't understand usages of constructor parameters with `super`
- Uncalled function checks need rhs-used-exemption for binary expression
- Inline JSDoc tags don't work in comments that start with plain text
- commonjs nested re-exports are broken