Sitelet https://web.archive.org/web/20220323030005/https://github.com/nodejs/node/pull/36032
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update wpt url and resource #36032

Closed
wants to merge 1 commit into from
Closed

Conversation

watilde
Copy link
Member

@watilde watilde commented Nov 8, 2020

percent-encoding.window.js file was added and will be paused to use as same as toascii.window.js for now.

Refs: web-platform-tests/wpt#26317

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@watilde watilde added test whatwg-url request-ci labels Nov 8, 2020
@github-actions github-actions bot removed the request-ci label Nov 9, 2020
@nodejs-github-bot

This comment has been hidden.

@watilde watilde added the dont-land-on-v14.x label Nov 9, 2020
Trott
Trott approved these changes Nov 9, 2020
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Nov 10, 2020

@watilde
Copy link
Member Author

@watilde watilde commented Nov 16, 2020

Let me cc @nodejs/url to request your review

targos
targos approved these changes Nov 16, 2020
@watilde watilde added author ready request-ci labels Nov 16, 2020
@github-actions github-actions bot removed the request-ci label Nov 17, 2020
@nodejs-github-bot

This comment has been hidden.

@watilde watilde added the request-ci label Nov 17, 2020
@github-actions github-actions bot removed the request-ci label Nov 17, 2020
@nodejs-github-bot

This comment has been hidden.

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented Nov 18, 2020

watilde added a commit that referenced this issue Nov 19, 2020
Refs: web-platform-tests/wpt#26317

PR-URL: #36032
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@watilde
Copy link
Member Author

@watilde watilde commented Nov 19, 2020

Landed in d6d4721

@watilde watilde closed this Nov 19, 2020
@watilde watilde deleted the wpt-url-update branch Nov 19, 2020
codebytere added a commit that referenced this issue Nov 22, 2020
Refs: web-platform-tests/wpt#26317

PR-URL: #36032
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@codebytere codebytere mentioned this pull request Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready dont-land-on-v14.x test whatwg-url
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants