Sitelet https://web.archive.org/web/20201018230119/https://github.com/codeclimate/codeclimate/pull/948
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added env var for image prefix to engine registry #948

Conversation

@sololegends
Copy link
Contributor

@sololegends sololegends commented May 10, 2020

Changes

Added environmen variable CODECLIMATE_PREFIX as an option for the codeclimate analyzer image prefix.

This will allow offline code quality scanning something huge for many orginazations

Impact

These changes won't impact any existing configurations. Anyone wanting to use this feature can , but no one will have to alter their environments to use a new image.

Testing

  • Tested pointing to a local docker registry (GOOD)
  • Tested swapping the codeclimate image in an environment already using codeclimate:0.85.8 (GOOD)
    • No changes required for functionality
  • Tested swapping the codeclimate image in an environment already using codeclimate:0.85.9 (GOOD)
    • No changes required for functionality
Added environmen variable CODECLIMATE_PREFIX as an option for the codeclimate analyzer image prefix. 

This will allow offline code quality scanning something huge for many orginazations
@CLAassistant
Copy link

@CLAassistant CLAassistant commented May 10, 2020 •

CLA assistant check
All committers have signed the CLA.

sololegends and others added 3 commits May 15, 2020
@goldenson
Copy link

@goldenson goldenson commented Sep 2, 2020

👋 @filipesperandio should we merge this MR as it has been approved?

@filipesperandio
Copy link
Collaborator

@filipesperandio filipesperandio commented Sep 2, 2020

My bad.
Got distracted and forgot to come back here.

@filipesperandio filipesperandio merged commit 0598d82 into codeclimate:master Sep 2, 2020
5 checks passed
5 checks passed
build_test Workflow: build_test
Details
codeclimate All good!
Details
codeclimate/diff-coverage 100% (80% threshold)
Details
codeclimate/total-coverage 96% (0.0% change)
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.