JS: Add support for JWT libraries#4638
Merged
Merged
Conversation
Co-authored-by: intrigus-lgtm <60750685+intrigus-lgtm@users.noreply.github.com>
asgerf
reviewed
Nov 11, 2020
| } | ||
|
|
||
| /** | ||
| * The public/private key for a JWT as a `CredentialsExpr`. |
Contributor
There was a problem hiding this comment.
Should we really treat the public key as a credential? Doesn't seem like a security issue to hard-code that.
Contributor
Author
There was a problem hiding this comment.
It can also use symmetric encryption.
That is actually the default.
Contributor
There was a problem hiding this comment.
I still think we should remove it from verify. If symmetric encryption is used we should still be able to pick up the same key via the sign call.
Co-authored-by: Asger F <asgerf@github.com>
asgerf
approved these changes
Nov 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.