C#: C#9 add test cases for discards as lambda/delegate parameters#4613
Merged
tamasvajk merged 2 commits intoNov 25, 2020
Conversation
3fdd60f to
33bc9bd
Compare
hvitved
previously approved these changes
Nov 24, 2020
33bc9bd to
0e59b91
Compare
0e59b91 to
6d95105
Compare
Contributor
Author
|
@hvitved I rebased this PR to fix the merge conflict. I also pushed an extra commit to adjust the |
hvitved
approved these changes
Nov 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was already some logic in place to make parameter names unique. This means that the second discard param will show up with the
_`1name whereever we display the name, such as in PrintAst.