Sitelet https://web.archive.org/web/20201107180537/https://github.com/spotify/logging-java/pull/36
Skip to content

/ logging-java

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default nonnull + spotbugs + fix warnings #36

Merged
merged 1 commit into from Nov 3, 2020
Merged

default nonnull + spotbugs + fix warnings #36

merged 1 commit into from Nov 3, 2020

Conversation

@danielnorberg
Copy link
Collaborator

@danielnorberg danielnorberg commented Oct 27, 2020 •
edited

  • Make everything @Nonnull by default
  • Configure spotbugs
  • Fix spotbugs warnings
  • Misc cleanup
@danielnorberg danielnorberg changed the title default nonnull + fix warnings default nonnull + spotbugs + fix warnings Oct 27, 2020
@danielnorberg
nonnull + spotbugs + cleanup
Loading status checks…
5469d59
@pettermahlen
pettermahlen approved these changes Oct 29, 2020
View changes
@danielnorberg
Copy link
Collaborator Author

@danielnorberg danielnorberg commented Nov 3, 2020

🙏
@danielnorberg danielnorberg merged commit 774d0f5 into master Nov 3, 2020
1 check passed
1 check passed
ci/circleci: test Your tests passed on CircleCI!
Details
@danielnorberg danielnorberg deleted the nonnull branch Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pettermahlen pettermahlen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@danielnorberg @pettermahlen
You can’t perform that action at this time.