Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[WIP] Switch project import to requests-toolbelt #1004
Closed
Conversation
|
@zapp42 Thanks for this MR! Looks good. Could you just format your code with black and change your commit message to something like:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Maybe this is of use for anybody. It works for me but I have not tested it thoroughly.
The Gitlab project import has lots of open issues, so your mileage may vary. Also I had to adapt the ProxyTimeout (Apache reverse proxy) and the unicorn['worker_timeout'] values.