add attestation test for off by one committee index #2119
Merged
Conversation
|
Some minor things, looks good otherwise |
| current_epoch = spec.get_current_epoch(state) | ||
| committee_count = spec.get_committee_count_per_slot(state, current_epoch) | ||
|
|
||
| attestation = get_valid_attestation(spec, state, index=0, signed=True) |
protolambda
Nov 3, 2020
Contributor
Had some doubt about signed=True when BLS is disabled, but it should still work, it just uses a different global BLS mock to sign, instead of not signing at all.
Had some doubt about signed=True when BLS is disabled, but it should still work, it just uses a different global BLS mock to sign, instead of not signing at all.
djrtwo
Nov 3, 2020
Author
Contributor
yeah, It's not really needed with the never_bls. I'll remove
yeah, It's not really needed with the never_bls. I'll remove
...pyspec/eth2spec/test/phase0/block_processing/test_process_attestation.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Diederik Loerakker <proto@protolambda.com>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Add test to cover off-by-one committee index case found by beaconfuzz -- prysmaticlabs/prysm#7684