Sitelet https://web.archive.org/web/20210103051643/https://github.com/ethereum/eth2.0-specs/pull/2107
Skip to content

/ eth2.0-specs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added best practices section according to https://github.com/ethereum… #2107

Merged
merged 5 commits into from Nov 4, 2020
Merged

added best practices section according to https://github.com/ethereum… #2107

merged 5 commits into from Nov 4, 2020

Conversation

@alonmuroch
Copy link
Contributor

@alonmuroch alonmuroch commented Oct 20, 2020 •
edited by djrtwo

addresses #2085
alonmuroch added 2 commits Oct 20, 2020
@alonmuroch
added best practices section according to #2085
Loading status checks…
73cd1a8
@alonmuroch
table of content
Loading status checks…
fe5e2f6
@dankrad
dankrad requested changes Oct 26, 2020
View changes
specs/phase0/validator.md Outdated Show resolved Hide resolved
specs/phase0/validator.md Outdated Show resolved Hide resolved
specs/phase0/validator.md Outdated Show resolved Hide resolved
specs/phase0/validator.md Outdated Show resolved Hide resolved
specs/phase0/validator.md Outdated Show resolved Hide resolved
specs/phase0/validator.md Outdated Show resolved Hide resolved
@alonmuroch @dankrad
Apply suggestions from Dankrad's code review
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0835c78 
Co-authored-by: dankrad <mail@dankradfeist.de>
@alonmuroch
Copy link
Contributor Author

@alonmuroch alonmuroch commented Oct 27, 2020

@dankrad thanks for the review, committed the changed you've suggested.
@alonmuroch
Copy link
Contributor Author

@alonmuroch alonmuroch commented Nov 4, 2020

@dankrad any other comments?
@djrtwo
djrtwo reviewed Nov 4, 2020
View changes
specs/phase0/validator.md Outdated Show resolved Hide resolved
@alonmuroch @djrtwo
Apply suggestions from code review
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5b95219 
Co-authored-by: Danny Ryan <dannyjryan@gmail.com>
@djrtwo djrtwo changed the base branch from dev to v1.0-candidate Nov 4, 2020
@djrtwo
djrtwo reviewed Nov 4, 2020
View changes
specs/phase0/validator.md Show resolved Hide resolved
@djrtwo
djrtwo reviewed Nov 4, 2020
View changes
specs/phase0/validator.md Outdated Show resolved Hide resolved
@alonmuroch @djrtwo
Apply suggestions from code review
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6996a89 
Co-authored-by: Danny Ryan <dannyjryan@gmail.com>
@djrtwo
djrtwo approved these changes Nov 4, 2020
View changes
@djrtwo djrtwo merged commit 2aa827c into ethereum:v1.0-candidate Nov 4, 2020
10 checks passed
10 checks passed
ci/circleci: build_deposit_contract Your tests passed on CircleCI!
Details
ci/circleci: checkout_specs Your tests passed on CircleCI!
Details
ci/circleci: codespell Your tests passed on CircleCI!
Details
ci/circleci: install_deposit_contract_web3_tester Your tests passed on CircleCI!
Details
ci/circleci: install_pyspec_test Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: table_of_contents Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test_deposit_contract Your tests passed on CircleCI!
Details
ci/circleci: test_deposit_contract_web3_tests Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dankrad dankrad

@djrtwo djrtwo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@alonmuroch @djrtwo @dankrad
You can’t perform that action at this time.