Sitelet https://web.archive.org/web/20220321073059/https://github.com/angular/angular/issues/39490
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Language service tags autocomplete for textarea and select as errors. #39490

Closed
derekkite opened this issue Oct 29, 2020 · 2 comments · Fixed by ngstack/translate#644
Closed

Language service tags autocomplete for textarea and select as errors. #39490

derekkite opened this issue Oct 29, 2020 · 2 comments · Fixed by ngstack/translate#644
Assignees
@crisbeto
Labels
comp: compiler P3 state: has PR
Milestone
Backlog

Comments

@derekkite
Copy link

@derekkite derekkite commented Oct 29, 2020

🐞 bug report

Affected Package

Compiler

Is this a regression?

No

Description

This is the error generated from ng build --prod
src/app/shared/user-input/user-input.component.html:5:7 - error NG8002: Can't bind to 'autocomplete' since it isn't a known property of 'textarea'.

5 [autocomplete]="config.autocomplete"
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/app/shared/user-input/user-input.component.ts:30:16
30 templateUrl: './user-input.component.html',
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Error occurs in the template of component UserInputComponent.
src/app/shared/user-input/user-input.component.html:44:7 - error NG8002: Can't bind to 'autocomplete' since it isn't a known property of 'select'.

44 [autocomplete]="config.autocomplete"

🔬 Minimal Reproduction

🔥 Exception or Error

🌍 Your Environment

Angular Version:

Anything else relevant?

https://github.com/angular/angular/blob/master/packages/compiler/src/schema/dom_element_schema_registry.ts#L143,L156 doesn't list autocomplete as an attribute for select and textarea.

This pull in 2017 says the schema was generated from Chrome
#17858

Chrome didn't support autocomplete in textarea and select in 2017. Support was added in 2018

https://www.chromestatus.com/feature/5680387573415936
@Airblader
Copy link
Contributor

@Airblader Airblader commented Oct 29, 2020

FYI, the workaround here is to use [attr.autocomplete]="…".

@ngbot ngbot bot added this to the needsTriage milestone Oct 29, 2020
@JoostK JoostK added the P3 label Oct 30, 2020
@ngbot ngbot bot removed this from the needsTriage milestone Oct 30, 2020
@ngbot ngbot bot added this to the Backlog milestone Oct 30, 2020
@crisbeto crisbeto self-assigned this Feb 20, 2021
crisbeto added a commit to crisbeto/angular that referenced this issue Feb 20, 2021
@crisbeto
fix(compiler): allow binding to autocomplete property on select and t…
4b4580c 
…extarea elements

Updates the schema to allow binding to the `autocomplete` property of a `textarea` or `select`.

Fixes angular#39490.
@crisbeto crisbeto mentioned this issue Feb 20, 2021
Closed
zarend added a commit that referenced this issue Mar 3, 2021
@crisbeto @zarend
fix(compiler): allow binding to autocomplete property on select and t…
20fb638 
…extarea elements (#40928)

Updates the schema to allow binding to the `autocomplete` property of a `textarea` or `select`.

Fixes #39490.

PR Close #40928
@dependabot dependabot bot mentioned this issue Mar 8, 2021
Merged
@dependabot dependabot bot mentioned this issue Mar 8, 2021
Closed
@dependabot dependabot bot mentioned this issue Mar 8, 2021
Closed
@dependabot dependabot bot mentioned this issue Mar 8, 2021
Closed
@dependabot dependabot bot mentioned this issue Mar 8, 2021
Closed
@dependabot dependabot bot mentioned this issue Mar 8, 2021
Closed
@dependabot dependabot bot mentioned this issue Mar 8, 2021
Closed
@dependabot dependabot bot mentioned this issue Mar 9, 2021
Closed
@dependabot dependabot bot mentioned this issue Mar 9, 2021
Closed
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Apr 3, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
comp: compiler P3 state: has PR
Projects
None yet
Milestone
Backlog
Linked pull requests

Successfully merging a pull request may close this issue.

Bump @angular/language-service from 11.2.3 to 11.2.4
5 participants
@JoostK @Airblader @crisbeto @derekkite @josephperrott