Sitelet https://web.archive.org/web/20201215064937/https://github.com/github/VisualStudio/pull/2013/commits
Skip to content

/ VisualStudio

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Adding more detail to PullRequestCheckView #2013

Open
wants to merge 38 commits into
base: master
from
Open

[WIP] Adding more detail to PullRequestCheckView #2013

wants to merge 38 commits into from

Commits on Oct 25, 2018

  1. Adding a second line to Checks in the PullRequestCheckView

    @StanleyGoldman
    StanleyGoldman committed Oct 25, 2018
    Loading status checks…
    Verified
    This commit was signed with a verified signature.
    StanleyGoldman Stanley Goldman
    GPG key ID: 7728F3B9BD13C8C3 Learn about signing commits
    25952ef

  2. Update checks list layout

    @donokuda
    donokuda committed Oct 25, 2018
    6c2e1c8

  3. Little bit of spacing and some text color formatting

    @donokuda
    donokuda committed Oct 25, 2018
    Loading status checks…
    2a8b50f

Commits on Oct 30, 2018

  1. Merge branch 'master' into check-second-line

    @StanleyGoldman
    StanleyGoldman committed Oct 30, 2018
    Loading status checks…
    Verified
    This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
    GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
    7a288d1

  2. Making duration status a tooltip

    @StanleyGoldman
    StanleyGoldman committed Oct 30, 2018
    Loading status checks…
    Verified
    This commit was signed with a verified signature.
    StanleyGoldman Stanley Goldman
    GPG key ID: 7728F3B9BD13C8C3 Learn about signing commits
    632c9fb

Commits on Oct 31, 2018

  1. Allow functionality to set ProtectedBranches

    @StanleyGoldman
    StanleyGoldman committed Oct 31, 2018
    Verified
    This commit was signed with a verified signature.
    StanleyGoldman Stanley Goldman
    GPG key ID: 7728F3B9BD13C8C3 Learn about signing commits
    406c5d4

Commits on Nov 1, 2018

  1. Merge branch 'octokit-graphql-update' into protected-branches

    @StanleyGoldman
    StanleyGoldman committed Nov 1, 2018
    Verified
    This commit was signed with a verified signature.
    StanleyGoldman Stanley Goldman
    GPG key ID: 7728F3B9BD13C8C3 Learn about signing commits
    8518c42

Commits on Nov 2, 2018

  1. Merge branch 'master' into check-second-line

    @StanleyGoldman
    StanleyGoldman committed Nov 2, 2018
    Loading status checks…
    Verified
    This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
    GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
    7e185c3

  2. GraphQL fix

    @StanleyGoldman
    StanleyGoldman committed Nov 2, 2018
    Verified
    This commit was signed with a verified signature.
    StanleyGoldman Stanley Goldman
    GPG key ID: 7728F3B9BD13C8C3 Learn about signing commits
    0b979b3

  3. Adding a second check for differing non-required statuses

    @StanleyGoldman
    StanleyGoldman committed Nov 2, 2018
    Verified
    This commit was signed with a verified signature.
    StanleyGoldman Stanley Goldman
    GPG key ID: 7728F3B9BD13C8C3 Learn about signing commits
    e17b44b

  4. Adding a required tag to PullRequestCheckViewModel

    @StanleyGoldman
    StanleyGoldman committed Nov 2, 2018
    Loading status checks…
    Verified
    This commit was signed with a verified signature.
    StanleyGoldman Stanley Goldman
    GPG key ID: 7728F3B9BD13C8C3 Learn about signing commits
    bc92842

  5. Fix compilation error

    @StanleyGoldman
    StanleyGoldman committed Nov 2, 2018
    Loading status checks…
    Verified
    This commit was signed with a verified signature.
    StanleyGoldman Stanley Goldman
    GPG key ID: 7728F3B9BD13C8C3 Learn about signing commits
    5d0c825

  6. Merge branch 'master' into protected-branches

    @StanleyGoldman
    StanleyGoldman committed Nov 2, 2018
    Loading status checks…
    Verified
    This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
    GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
    73134d9

Commits on Nov 6, 2018

  1. Merge branch 'master' into check-second-line

    @StanleyGoldman
    StanleyGoldman committed Nov 6, 2018
    Loading status checks…
    Verified
    This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
    GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
    c816c8d

Commits on Nov 8, 2018

  1. Merge branch 'master' into check-second-line

    @StanleyGoldman
    StanleyGoldman committed Nov 8, 2018
    Loading status checks…
    Verified
    This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
    GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
    a7e3fcb

Commits on Dec 12, 2018

  1. Merge remote-tracking branch 'origin/master' into check-second-line 

    # Conflicts:
#	src/GitHub.App/ViewModels/GitHubPane/PullRequestCheckViewModel.cs
#	src/GitHub.Exports.Reactive/ViewModels/GitHubPane/IPullRequestCheckViewModel.cs
#	src/GitHub.Exports/Models/CheckRunModel.cs
#	src/GitHub.InlineReviews/Services/PullRequestSessionService.cs
#	src/GitHub.VisualStudio.UI/Views/GitHubPane/PullRequestCheckView.xaml
    @StanleyGoldman
    StanleyGoldman committed Dec 12, 2018
    Loading status checks…
    1d0b8d2

  2. Fixes needed for compilation

    @StanleyGoldman
    StanleyGoldman committed Dec 12, 2018
    Loading status checks…
    6e03523

  3. Fixing formatting

    @StanleyGoldman
    StanleyGoldman committed Dec 12, 2018
    Loading status checks…
    51a00c7

Commits on Dec 13, 2018

  1. Merge remote-tracking branch 'origin/master' into check-second-line

    @StanleyGoldman
    StanleyGoldman committed Dec 13, 2018
    Verified
    This commit was signed with a verified signature.
    StanleyGoldman Stanley Goldman
    GPG key ID: 7728F3B9BD13C8C3 Learn about signing commits
    cefc43a

  2. Fxing how the model is populated

    @StanleyGoldman
    StanleyGoldman committed Dec 13, 2018
    Loading status checks…
    Verified
    This commit was signed with a verified signature.
    StanleyGoldman Stanley Goldman
    GPG key ID: 7728F3B9BD13C8C3 Learn about signing commits
    a489cbe

  3. Merge remote-tracking branch 'origin/master' into protected-branches 

    # Conflicts:
#	src/GitHub.App/Services/PullRequestService.cs
#	src/GitHub.App/ViewModels/GitHubPane/PullRequestCheckViewModel.cs
#	src/GitHub.Exports.Reactive/Collections/TrackingCollection.cs
#	src/GitHub.Exports.Reactive/ViewModels/GitHubPane/IPullRequestDetailViewModel.cs
#	src/GitHub.Exports/Models/CheckRunModel.cs
#	src/GitHub.VisualStudio.UI/Views/GitHubPane/PullRequestCheckView.xaml
#	test/GitHub.App.UnitTests/ViewModels/GitHubPane/PullRequestCreationViewModelTests.cs
    @StanleyGoldman
    StanleyGoldman committed Dec 13, 2018
    Verified
    This commit was signed with a verified signature.
    StanleyGoldman Stanley Goldman
    GPG key ID: 7728F3B9BD13C8C3 Learn about signing commits
    8f91ca3

  4. Merge branch 'check-second-line' into protected-branches 

    # Conflicts:
#	src/GitHub.VisualStudio.UI/Views/GitHubPane/PullRequestCheckView.xaml
    @StanleyGoldman
    StanleyGoldman committed Dec 13, 2018
    Loading status checks…
    Verified
    This commit was signed with a verified signature.
    StanleyGoldman Stanley Goldman
    GPG key ID: 7728F3B9BD13C8C3 Learn about signing commits
    3f0ac46

  5. Reverting functionality to process protected branches in the pull req… 

    …uest list view
    @StanleyGoldman
    StanleyGoldman committed Dec 13, 2018
    Loading status checks…
    Verified
    This commit was signed with a verified signature.
    StanleyGoldman Stanley Goldman
    GPG key ID: 7728F3B9BD13C8C3 Learn about signing commits
    f25c488

  6. Repositioning

    @StanleyGoldman
    StanleyGoldman committed Dec 13, 2018
    Verified
    This commit was signed with a verified signature.
    StanleyGoldman Stanley Goldman
    GPG key ID: 7728F3B9BD13C8C3 Learn about signing commits
    1cf3c80

  7. Cleanup

    @StanleyGoldman
    StanleyGoldman committed Dec 13, 2018
    Loading status checks…
    Verified
    This commit was signed with a verified signature.
    StanleyGoldman Stanley Goldman
    GPG key ID: 7728F3B9BD13C8C3 Learn about signing commits
    018fdab

  8. Merge pull request #2029 from github/protected-branches 

    Adding indications for protected branches
    @StanleyGoldman
    StanleyGoldman committed Dec 13, 2018
    Loading status checks…
    Verified
    This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
    GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
    bda657a

  9. Comments

    @StanleyGoldman
    StanleyGoldman committed Dec 13, 2018
    Loading status checks…
    Verified
    This commit was signed with a verified signature.
    StanleyGoldman Stanley Goldman
    GPG key ID: 7728F3B9BD13C8C3 Learn about signing commits
    95bb822

  10. Removing unused enum

    @StanleyGoldman
    StanleyGoldman committed Dec 13, 2018
    Loading status checks…
    Verified
    This commit was signed with a verified signature.
    StanleyGoldman Stanley Goldman
    GPG key ID: 7728F3B9BD13C8C3 Learn about signing commits
    b7d9d2e

  11. More comments

    @StanleyGoldman
    StanleyGoldman committed Dec 13, 2018
    Loading status checks…
    Verified
    This commit was signed with a verified signature.
    StanleyGoldman Stanley Goldman
    GPG key ID: 7728F3B9BD13C8C3 Learn about signing commits
    20690ea

  12. Flailing a little

    @donokuda
    donokuda committed Dec 13, 2018
    a3cb52f

Commits on Dec 14, 2018

  1. Use a dock panel layout

    @donokuda
    donokuda committed Dec 14, 2018
    1a46be8

  2. Theming

    @donokuda
    donokuda committed Dec 14, 2018
    2a9402e

  3. uncomment visibility condition

    @donokuda
    donokuda committed Dec 14, 2018
    Loading status checks…
    6691ab7

Commits on Feb 26, 2019

  1. Merge branch 'master' into check-second-line 

    # Conflicts:
#	src/GitHub.InlineReviews/Services/PullRequestSessionService.cs
#	src/GitHub.Resources/Resources.zh-CN.resx
#	src/GitHub.VisualStudio.UI/Styles/ThemeBlue.xaml
#	src/GitHub.VisualStudio.UI/Styles/ThemeDark.xaml
#	src/GitHub.VisualStudio.UI/Styles/ThemeLight.xaml
    @StanleyGoldman
    StanleyGoldman committed Feb 26, 2019
    Loading status checks…
    Verified
    This commit was signed with a verified signature.
    StanleyGoldman Stanley Goldman
    GPG key ID: 7728F3B9BD13C8C3 Learn about signing commits
    fbf9bef

  2. Merge branch 'master' into check-second-line

    @StanleyGoldman
    StanleyGoldman committed Feb 26, 2019
    Loading status checks…
    Verified
    This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
    GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
    6fb41a2

  3. Fixing view

    @StanleyGoldman
    StanleyGoldman committed Feb 26, 2019
    Loading status checks…
    Verified
    This commit was signed with a verified signature.
    StanleyGoldman Stanley Goldman
    GPG key ID: 7728F3B9BD13C8C3 Learn about signing commits
    fa4add2

Commits on Feb 27, 2019

  1. Fix line spacing issues between check titles and descriptions

    @donokuda
    donokuda committed Feb 27, 2019
    f3b746c

  2. Leave enough space for the Required Badge

    @donokuda
    donokuda committed Feb 27, 2019
    Loading status checks…
    8bec5f0
You can’t perform that action at this time.