Update crypto.md #34930
Closed
Update crypto.md #34930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
align to function signature
joyeecheung
approved these changes
Aug 27, 2020
rickyes
approved these changes
Sep 10, 2020
Commit Queue failed- Loading data for nodejs/node/pull/34930 ✔ Done loading data for nodejs/node/pull/34930 ----------------------------------- PR info ------------------------------------ Title Update crypto.md (#34930) Author anlex N <1293006794@qq.com> (@anlexN, first-time contributor) Branch anlexN:patch-1 -> nodejs:master Labels author ready, crypto, doc Commits 1 - Update crypto.md Committers 1 - GitHub PR-URL: https://github.com/nodejs/node/pull/34930 Reviewed-By: Joyee Cheung Reviewed-By: Ricky Zhou <0x19951125@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/34930 Reviewed-By: Joyee Cheung Reviewed-By: Ricky Zhou <0x19951125@gmail.com> -------------------------------------------------------------------------------- ✔ Last GitHub Actions successful ℹ Doc-only changes ℹ This PR was created on Wed, 26 Aug 2020 09:29:44 GMT ✔ Approvals: 2 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/34930#pullrequestreview-476765948 ✔ - Ricky Zhou (@rickyes): https://github.com/nodejs/node/pull/34930#pullrequestreview-486026424 -------------------------------------------------------------------------------- ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD ✔ origin/master is now up-to-date - Downloading patch for 34930 ✔ Downloaded patch to /home/runner/work/node/node/.ncu/34930/patch -------------------------------------------------------------------------------- Applying: Update crypto.md ✔ Patches applied -------------------------------------------------------------------------------- --------------------------------- New Message ---------------------------------- Update crypto.md |
trivikr
approved these changes
Sep 17, 2020
gengjiawen
approved these changes
Sep 30, 2020
gengjiawen
pushed a commit
that referenced
this issue
Sep 30, 2020
PR-URL: #34930 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
|
Landed in c7e3b0b |
|
Thanks for the contribution |
danielleadams
pushed a commit
that referenced
this issue
Oct 6, 2020
PR-URL: #34930 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Merged
joesepi
pushed a commit
to joesepi/node
that referenced
this issue
Jan 8, 2021
PR-URL: nodejs#34930 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
align to function signature
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes