Sitelet https://web.archive.org/web/20220322223628/https://github.com/nodejs/node/pull/34197
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove errors that have never been released #34197

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 4, 2020

Refs: #33764 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc errors labels Jul 4, 2020
@Trott Trott added the author ready label Jul 4, 2020
trivikr
trivikr approved these changes Jul 5, 2020
jasnell
jasnell approved these changes Jul 5, 2020
@Trott Trott force-pushed the srsly-rm-never-released branch from 9b02bc2 to fcce614 Compare Jul 6, 2020
jasnell added a commit that referenced this issue Jul 6, 2020
Refs: #33764 (comment)

PR-URL: #34197
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

@jasnell jasnell commented Jul 6, 2020

Landed in bf77289

@jasnell jasnell closed this Jul 6, 2020
MylesBorins added a commit that referenced this issue Jul 14, 2020
Refs: #33764 (comment)

PR-URL: #34197
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 14, 2020
MylesBorins added a commit that referenced this issue Jul 16, 2020
Refs: #33764 (comment)

PR-URL: #34197
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere added a commit that referenced this issue Sep 27, 2020
Refs: #33764 (comment)

PR-URL: #34197
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax added a commit that referenced this issue Sep 28, 2020
Refs: #33764 (comment)

PR-URL: #34197
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax addaleax added the dont-land-on-v12.x label Sep 28, 2020
@codebytere codebytere mentioned this pull request Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready doc dont-land-on-v12.x errors
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants