tools: update ESLint from 7.2.0 to 7.3.0 #34000
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since we are here, I've noted that |
The entire diff between 7.3.1 and 7.3.0 is below. No dependencies changed. I think it's OK to update this branch for 7.3.1 and land. diff --git a/tools/node_modules/eslint/lib/cli-engine/config-array-factory.js b/tools/node_modules/eslint/lib/cli-engine/config-array-factory.js
index 6d0992151a..39f62bb6da 100644
--- a/tools/node_modules/eslint/lib/cli-engine/config-array-factory.js
+++ b/tools/node_modules/eslint/lib/cli-engine/config-array-factory.js
@@ -722,7 +722,12 @@ class ConfigArrayFactory {
*
* Refer https://github.com/eslint/eslint/issues/12592
*/
- const clonedRulesConfig = rules && JSON.parse(JSON.stringify((rules)));
+ const clonedRulesConfig = rules && JSON.parse(
+ JSON.stringify(
+ rules,
+ (key, value) => (value === Infinity ? Number.MAX_SAFE_INTEGER : value)
+ )
+ );
// Flatten `extends`.
for (const extendName of extendList.filter(Boolean)) {
diff --git a/tools/node_modules/eslint/package.json b/tools/node_modules/eslint/package.json
index ab91e08db2..8f7acd95eb 100644
--- a/tools/node_modules/eslint/package.json
+++ b/tools/node_modules/eslint/package.json
@@ -153,5 +153,5 @@
"test:cli": "mocha",
"webpack": "node Makefile.js webpack"
},
- "version": "7.3.0"
+ "version": "7.3.1"
}
\ No newline at end of file |
Trott
added a commit
that referenced
this issue
Jun 23, 2020
PR-URL: #34000 Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Trott
added a commit
that referenced
this issue
Jun 23, 2020
PR-URL: #34000 Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
|
Landed in db0e991...076e4ed |
|
@Trott for some reason removing the comment in that test file fails on node on git:v14.x-staging ❯ make lint 11:22AM
Running JS linter...
/Users/codebytere/Developer/node/test/known_issues/test-crypto-authenticated-stream.js
5:16 error Please add a hasCrypto check to allow this test to be skipped when Node is built "--without-ssl" node-core/crypto-check
✖ 1 problem (1 error, 0 warnings)
make[1]: *** [lint-js] Error 1
make[1]: Nothing to be done for `lint-cpp'.
make[1]: Nothing to be done for `lint-addon-docs'.
make[1]: Nothing to be done for `lint-md'.
make: *** [lint] Error 2Any idea what might be up? |
|
@codebytere Have you tried to backport #33981? That is the PR for which that error has been fixed on master. |
|
@addaleax ah gotcha - that one'll need a manual backport (just requested one) so i'll mark these blocked on that for now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Lots of files changed this time, but it's mostly deletions.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes