Sitelet https://web.archive.org/web/20220420043128/https://github.com/nodejs/node/commit/d953fa3038
Skip to content
Permalink
Browse files
src: usage of modernize-use-equals-default
Update the destructor and constructor calls to use the default member
function. This will bascially enable the compiler to do better
optimization as the functions as explicitly defined as trivial.

Refs: https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-equals-default.html

PR-URL: #34807
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
yashLadha authored and addaleax committed Sep 22, 2020
1 parent c059d3d commit d953fa3038c702d6fcec062864b7a5965d6470d9
Showing with 2 additions and 2 deletions.
  1. +2 −2 src/node_file.cc
@@ -126,9 +126,9 @@ void FSContinuationData::MemoryInfo(MemoryTracker* tracker) const {
tracker->TrackField("paths", paths_);
}

FileHandleReadWrap::~FileHandleReadWrap() {}
FileHandleReadWrap::~FileHandleReadWrap() = default;

FSReqBase::~FSReqBase() {}
FSReqBase::~FSReqBase() = default;

void FSReqBase::MemoryInfo(MemoryTracker* tracker) const {
tracker->TrackField("continuation_data", continuation_data_);

0 comments on commit d953fa3

Please sign in to comment.