Sitelet https://web.archive.org/web/20220320082153/https://github.com/nodejs/node/commit/bd71cdf153
Skip to content
Permalink
Browse files
test: use common.buildType in embedding test
This un-breaks testing in the case of `./configure --debug-node`.

Backport-PR-URL: #35241
PR-URL: #32422
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
addaleax committed Sep 23, 2020
1 parent bdf6d41 commit bd71cdf1534135be01ed432d4ca3bff2237372a2
Showing with 1 addition and 2 deletions.
  1. +1 −2 test/embedding/test-embedding.js
@@ -6,8 +6,7 @@ const child_process = require('child_process');
const path = require('path');

common.allowGlobals(global.require);
let binary = process.features.debug ?
'out/Debug/embedtest' : 'out/Release/embedtest';
let binary = `out/${common.buildType}/embedtest`;
if (common.isWindows) {
binary += '.exe';
}

0 comments on commit bd71cdf

Please sign in to comment.