Sitelet https://web.archive.org/web/20210413145846/https://github.com/nodejs/nodejs.org/pull/2712
Skip to content

/ nodejs.org

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Collaborator Guide #2712

Merged
merged 2 commits into from Oct 22, 2019
Merged

fix: Collaborator Guide #2712

merged 2 commits into from Oct 22, 2019

Conversation

@nschonni
Copy link
Member

@nschonni nschonni commented Oct 22, 2019

  • Replace inline triple backticks
  • Add code fence languages
  • behaviour -> behavior
  • contstraints -> constraints
  • Remove bold as heading
@nschonni
fix: Collaborator Guide
Loading status checks…
7b5968d 
- Replace inline triple backticks
- Add code fence languages
- behaviour -> behavior
- contstraints -> constraints
- Remove bold as heading
@Aissaoui-Ahmed
Aissaoui-Ahmed approved these changes Oct 22, 2019
View changes
Copy link
Member

@Aissaoui-Ahmed Aissaoui-Ahmed left a comment

LGTM
@lpinca
lpinca approved these changes Oct 22, 2019
View changes
@Trott
Merge branch 'master' into fix--Collaborator-Guide
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f600d06
@Trott Trott merged commit 1e0a1a3 into nodejs:master Oct 22, 2019
1 check passed
1 check passed
test
Details
@nschonni nschonni deleted the nschonni:fix--Collaborator-Guide branch Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca

@Aissaoui-Ahmed Aissaoui-Ahmed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@nschonni @lpinca @Aissaoui-Ahmed @Trott