Sitelet https://web.archive.org/web/20201025233322/https://github.com/nodejs/node/issues/35783
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8 coverage API next steps #35783

Open
joyeecheung opened this issue Oct 23, 2020 · 0 comments
Open

V8 coverage API next steps #35783

joyeecheung opened this issue Oct 23, 2020 · 0 comments
Assignees
Labels

Comments

@joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Oct 23, 2020 •

Opening an issue to track the work before moving v8.startCoverage() and v8.stopCoverage() out of experiment. This will take some refactoring. See #33807 (comment) and #33807 (comment)

  1. Add a v8.startCoverage() method to reuse the per-env connection, if NODE_V8_COVERAGE is not set (would be useful to restart after v8.stopCoverage())
  2. It would be good to have an API that (optionally?) returns the coverage result. I think it should be v8.takeCoverage() as the Profiler.stopPreciseCoverage command doesn't return this but the Profiler.takePreciseCoverage does. Also, I realize that this method should be asynchronous as there's no guarantee that we can get the response from inspector synchronously (it just happens to be this way right now), so it should probably return a promise.
  3. Error reporting can be improved (return a rejection?)

Also #35212

@joyeecheung joyeecheung self-assigned this Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.