Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUnsupported private class error doesn't throw on building library for production #17518
Comments
|
@robertIsaac, the problem here is that the above is only an error when using Ivy rendering engine, with View Engine which is used for production builds, this is valid. That said, we should add the export to the public api when using the schematics so that we generate valid code for both rendering engines. |
Command (mark with an
x)Is this a regression?
i'm not sure
Description
when i export a component in the library module but not in the public API
the build command throw errors only in normal mode, but in production mode it completes successfully
clone https://github.com/robertIsaac/test-library
and run ng b and ng b --prod
or generate from scratch
both commands should throw the following error
Anything else relevant?
it would be nice if --export command also update the public api file if it's running inside a library